Summary

Create PurpleBadgeManager

Review Request #3666 — Created Nov. 22, 2024 and submitted Nov. 22, 2024, 5:40 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This is a cache for Purple.Badge instance to help protocols and plugins from
needing to create multiple instances or create their own caches.

Testing Done

Ran the unit tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Create PurpleBadgeManager This is a cache for Purple.Badge instance to help protocols and plugins from needing to create multiple instances or create their own caches.	5410ed3fb4acde00788a3f7e358a6821867ceb05

Issues

Description	From	Last Updated
No need for G_OBJECT here, I think.	QuLogic	Nov. 22, 2024, 5:34 a.m.
Don't remember what the default is, but this should probably be (transfer none).	QuLogic	Nov. 22, 2024, 5:34 a.m.
our	QuLogic	Nov. 22, 2024, 5:34 a.m.

libpurple/purplebadgemanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
No need for G_OBJECT here, I think.
```
libpurple/purplebadgemanager.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Don't remember what the default is, but this should probably be (transfer none).
```
libpurple/tests/test_badge_manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
our
```

Change Summary:

Updated issues and beefed up the unit tests a bit.

Commits:

	Summary	ID
	Create PurpleBadgeManager This is a cache for Purple.Badge instance to help protocols and plugins from needing to create multiple instances or create their own caches.	4f6e34125b19cfded1fdc5f73e20db5b30c7a161
	Create PurpleBadgeManager This is a cache for Purple.Badge instance to help protocols and plugins from needing to create multiple instances or create their own caches.	5410ed3fb4acde00788a3f7e358a6821867ceb05

Diff:

	libpurple/meson.build
	libpurple/purplebadgemanager.h
	libpurple/purplebadgemanager.c
	libpurple/tests/meson.build
	libpurple/tests/test_badge_manager.c

Ship it!