Summary

Fix uses of PurpleAccount as a PurpleContactInfo

Review Request #3665 — Created Nov. 22, 2024 and submitted Nov. 22, 2024, 4:13 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This was changed from is-a to has-a relationship in /r/3157.

Testing Done

Compiled only (and not even that for wincred, tbh)

Commits

Summary	ID
Fix uses of PurpleAccount as a PurpleContactInfo This was changed from is-a to has-a relationship in /r/3157.	7d4f47ccea27e84ed1f3dae74dbb3ee35d7d0b6b

Issues

Description	From	Last Updated
Not sure if this actually is set to anything or whether it should use purple_account_get_username instead.	QuLogic	Nov. 22, 2024, 4:11 a.m.

libpurple/purpleaccount.c (Diff revision 1)

The issue has been resolved. Show all issues

Not sure if this actually is set to anything or whether it should use purple_account_get_username instead.

Yeah lets just make this use the username.

There's a bunch of stuff broken on windows, i have a branch started but not finished.

Change Summary:

Use the username in the password error debug message.

Commits:

	Summary	ID
	Fix uses of PurpleAccount as a PurpleContactInfo This was changed from is-a to has-a relationship in /r/3157.	52c409c8495258e7a64d7c31f0bc2566bd7dcbf6
	Fix uses of PurpleAccount as a PurpleContactInfo This was changed from is-a to has-a relationship in /r/3157.	7d4f47ccea27e84ed1f3dae74dbb3ee35d7d0b6b

Diff:

	libpurple/purpleaccount.c
	libpurple/plugins/wincred/wincred.c

Ship it!