Summary

IRCv3: Display the contents of ERROR messages in the status window

Review Request #3659 — Created Nov. 17, 2024 and submitted Nov. 21, 2024, 6:21 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Also added support for the 465 NUMERIC.

Testing Done

Got zlined from one of my local ircd's to verify.

Commits

Summary	ID
IRCv3: Display the contents of ERROR messages in the status window	310eb00fd9ea6120d79db36e50899c230d6fb762

Files

Issues

Description	From	Last Updated
Is this block still necessary, since it's documented in the header now?	ivanhoe	Nov. 19, 2024, 4:17 p.m.
Should be purple_ircv3_connection_write_status_message now.	ivanhoe	Nov. 19, 2024, 4:17 p.m.
Shouldn't this also say Since: 3.0 now?	ivanhoe	Nov. 19, 2024, 4:17 p.m.

protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Is this block still necessary, since it's documented in the header now?
```
protocols/ircv3/purpleircv3connection.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Should be purple_ircv3_connection_write_status_message now.
```
protocols/ircv3/purpleircv3connection.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Shouldn't this also say Since: 3.0 now?
```

Change Summary:

addressed issues

Commits:

	Summary	ID
	IRCv3: Display the contents of ERROR messages in the status window	f0d8eda3812e773ae6ad25fc3b0f94267364a2df
	IRCv3: Display the contents of ERROR messages in the status window	310eb00fd9ea6120d79db36e50899c230d6fb762

Diff:

Revision 2 (+138 -112)

	protocols/ircv3/purpleircv3connection.h
	protocols/ircv3/purpleircv3connection.c
	protocols/ircv3/purpleircv3messagehandlers.c

Ship it!

Ship it!