Summary

Add Purple.ProtocolConversation.implements_send_message

Review Request #3648 — Created Nov. 5, 2024 and submitted Nov. 10, 2024, 8:30 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is a helper method to make sure that a protocol has implemented everything
that is necessary to send a message. I also found a bunch of missing unit tests
for other "implements" checks that I now added.

Testing Done

Ran the unit tests under valgrind, called in the turtles, and sent some messages on ircv3.

Commits

Summary	ID
Add Purple.ProtocolConversation.implements_send_message This is a helper method to make sure that a protocol has implemented everything that is necessary to send a message. I also found a bunch of missing unit tests for other "implements" checks that I now added.	b7a6468f56ed4f8c09383d301b0fc86d9e161d58

Issues

Description	From	Last Updated
a protocol	QuLogic	Nov. 10, 2024, 8:29 a.m.
s/implementes/implements/	QuLogic	Nov. 10, 2024, 8:29 a.m.
s/implementes/implements/	QuLogic	Nov. 10, 2024, 8:29 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Add Purple.ProtocolConversation.implements_send_message This is a helper method to make sure that a protocol has implemented everything that is necessary to send a message. I also found a bunch of missing unit tests for other "implements" checks that I now added.	a71b044ff8e471781ecf4cc8b519df9095108c71
	Add commands for say and action This includes unit tests for the commands and they are also added to the default command manager by default.	ae485d431c26b25a08809c181cbf3d724a36c053

Diff:

Revision 2 (+830)

Show changes

	libpurple/meson.build
	libpurple/purplecommandmanager.c
	libpurple/purplecommands.h
	libpurple/purplecommands.c
	libpurple/tests/meson.build
	libpurple/tests/test_commands.c

Change Summary:

rebased and pushed the correct branch this time..

Commits:

	Summary	ID
	Add commands for say and action This includes unit tests for the commands and they are also added to the default command manager by default.	ae485d431c26b25a08809c181cbf3d724a36c053
	Add Purple.ProtocolConversation.implements_send_message This is a helper method to make sure that a protocol has implemented everything that is necessary to send a message. I also found a bunch of missing unit tests for other "implements" checks that I now added.	97e6e1f9a74d3b667276a46ea9c06240cae65d10

Diff:

Revision 3 (+246 -12)

Show changes

	libpurple/purpleconversation.c
	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

libpurple/purpleprotocolconversation.h (Diff revision 3)
The issue has been resolved. Show all issues
```
a protocol
```
libpurple/tests/test_protocol_conversation.c (Diff revision 3)
The issue has been resolved. Show all issues
```
s/implementes/implements/
```
libpurple/tests/test_protocol_conversation.c (Diff revision 3)
The issue has been resolved. Show all issues
```
s/implementes/implements/
```

Change Summary:

Fix issues and fix another issue with the unit tests

Commits:

	Summary	ID
	Add Purple.ProtocolConversation.implements_send_message This is a helper method to make sure that a protocol has implemented everything that is necessary to send a message. I also found a bunch of missing unit tests for other "implements" checks that I now added.	97e6e1f9a74d3b667276a46ea9c06240cae65d10
	Add Purple.ProtocolConversation.implements_send_message This is a helper method to make sure that a protocol has implemented everything that is necessary to send a message. I also found a bunch of missing unit tests for other "implements" checks that I now added.	b7a6468f56ed4f8c09383d301b0fc86d9e161d58

Diff:

Revision 4 (+246 -12)

Show changes

	libpurple/purpleconversation.c
	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Ship it!

```
Ship It!
```

Status:: Completed