Summary

Clean up Purple.ProtocolManager and add some basic unit tests

Review Request #3638 — Created Nov. 2, 2024 and submitted Nov. 3, 2024, 5:19 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Clean up Purple.ProtocolManager and add some basic unit tests

Testing Done

Ran the tests under valgrind and called in the turtles for everyting else. Also ran in a devenv and verified my demo and irc accounts connected.

Commits

Summary	ID
Clean up Purple.ProtocolManager and add some basic unit tests	55c2e70b17e21e257ef400a3e68b7f2b9918b1bf

Issues

Description	From	Last Updated
Doesn't this need g_object_unref?	QuLogic	Nov. 3, 2024, 5:14 a.m.

libpurple/purpleprotocolmanager.c (Diff revision 1)

The issue has been resolved. Show all issues

Doesn't this need g_object_unref?

Yep, good catch. The unit tests didn't see this as a leak because the unit tests don't add any items yet...

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Clean up Purple.ProtocolManager and add some basic unit tests	fcb3a3201fb56d981b216b29c3e1cb4885453ae1
	Clean up Purple.ProtocolManager and add some basic unit tests	55c2e70b17e21e257ef400a3e68b7f2b9918b1bf

Diff:

Revision 2 (+272 -76)

	libpurple/purpleprotocolmanager.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_manager.c

Ship it!