Summary

Update Purple.CredentialManager to implement Gio.ListModel

Review Request #3635 — Created Nov. 2, 2024 and submitted Nov. 3, 2024, 12:13 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

3641

Reviewers

Groups

pidgin

People

Description

This required changing the internal data type from a GLib.HashTable to a
GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as
the Gio.ListModel interface makes it redundant.

Testing Done

Ran the tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	ee2f3294ef6e4f3c96dd8f3cb3a21662cf7feb8e

Issues

Description	From	Last Updated
This seems misaligned.	QuLogic	Nov. 3, 2024, 12:06 a.m.

Change Summary:

implement the list model properties.

Commits:

	Summary	ID
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	f469ddfb15d504a903340ec56911e719d47d6049
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	903cb1074f2b7c9a9d3b3bb116916c1c2f61aa5e

Diff:

Revision 2 (+356 -60)

Show changes

	libpurple/purplecredentialmanager.h
	libpurple/purplecredentialmanager.c
	libpurple/tests/test_credential_manager.c

Change Summary:

Call g_list_model_items_changed as necessary.

Commits:

	Summary	ID
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	903cb1074f2b7c9a9d3b3bb116916c1c2f61aa5e
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	70735bfa51593b5bec8b9bcb4f78c12790129f9a

Diff:

Revision 3 (+514 -60)

Show changes

	libpurple/purplecredentialmanager.h
	libpurple/purplecredentialmanager.c
	libpurple/tests/test_credential_manager.c

Change Summary:

Add a get_default_as_model method.

Commits:

	Summary	ID
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	70735bfa51593b5bec8b9bcb4f78c12790129f9a
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	31bc8535da8563043b8287b482404010a5882e0c

Diff:

Revision 4 (+558 -60)

Show changes

	libpurple/purplecredentialmanager.h
	libpurple/purplecredentialmanager.c
	libpurple/tests/test_credential_manager.c

libpurple/purplecredentialmanager.c (Diff revision 4)
The issue has been resolved. Show all issues
```
This seems misaligned.
```

Change Summary:

Fix alignment

Commits:

	Summary	ID
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	31bc8535da8563043b8287b482404010a5882e0c
	Update Purple.CredentialManager to implement Gio.ListModel This required changing the internal data type from a GLib.HashTable to a GLib.PtrArray. Purple.CredentialManager.foreach has also been deprecated as the Gio.ListModel interface makes it redundant.	ee2f3294ef6e4f3c96dd8f3cb3a21662cf7feb8e

Diff:

Revision 5 (+560 -62)

Show changes

	libpurple/purplecredentialmanager.h
	libpurple/purplecredentialmanager.c
	libpurple/tests/test_credential_manager.c

Ship it!

```
Ship It!
```

Status:: Completed