Summary

Change the internal data structure of Purple.ConversationManager to GPtrArray

Review Request #3634 — Created Nov. 2, 2024 and submitted Nov. 2, 2024, 8:31 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

I also implemented Gio.ListModel as it was barely any code to do it and added Purple.ConversationManager.get_default_as_model as well.

Testing Done

Ran the conversation-manager tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Change the internal data structure of Purple.ConversationManager to GPtrArray This is the first step of making it implement GListModel. I opted to do this separately to keep the changes simple.	4d2520bad2e89dd9c36d59d754db51c14b31d757

Issues

Description	From	Last Updated
We also add item-type and n-items properties.	QuLogic	Nov. 2, 2024, 8:25 a.m.
This comment is in the wrong spot now.	QuLogic	Nov. 2, 2024, 8:25 a.m.

Description:

~		This is the first step of making it implement GListModel. I opted to do this
	~	I also implemented Gio.ListModel as it was barely any code to do it and added Purple.ConversationManager.get_default_as_model as well.
-		separately to keep the changes simple.

Commits:

	Summary	ID
	Change the internal data structure of Purple.ConversationManager to GPtrArray This is the first step of making it implement GListModel. I opted to do this separately to keep the changes simple.	0b10bfcdb12ce1205ee3541d655c22ba6fc23ecf
	Change the internal data structure of Purple.ConversationManager to GPtrArray This is the first step of making it implement GListModel. I opted to do this separately to keep the changes simple.	f913fade6a914b26e179bbafb25eb1456bb23b11

Diff:

Revision 2 (+250 -118)

	libpurple/purpleconversationmanager.h
	libpurple/purpleconversationmanager.c
	libpurple/tests/test_conversation_manager.c

libpurple/purpleconversationmanager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
We also add item-type and n-items properties.
```
libpurple/purpleconversationmanager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
This comment is in the wrong spot now.
```

Change Summary:

add properties and fix comment location

Commits:

	Summary	ID
	Change the internal data structure of Purple.ConversationManager to GPtrArray This is the first step of making it implement GListModel. I opted to do this separately to keep the changes simple.	f913fade6a914b26e179bbafb25eb1456bb23b11
	Change the internal data structure of Purple.ConversationManager to GPtrArray This is the first step of making it implement GListModel. I opted to do this separately to keep the changes simple.	4d2520bad2e89dd9c36d59d754db51c14b31d757

Diff:

Revision 3 (+320 -118)

	libpurple/purpleconversationmanager.h
	libpurple/purpleconversationmanager.c
	libpurple/tests/test_conversation_manager.c

Ship it!