Summary

Rename Purple.ConversationManager.register/unregister to add/remove

Review Request #3621 — Created Nov. 1, 2024 and submitted Nov. 1, 2024, 4:55 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

Groups

People

Description

I also cleaned up some legacy work arounds that were missed then conversations
were no longer auto added to the conversation manager.

Testing Done

Ran the conversation manager, history manager, and history adapter tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Rename Purple.Conversationmanager.register/unregister to add/remove I also cleaned up some legacy work arounds that were missed then conversations were no longer auto added to the conversation manager.	2ae1bf0c87fc404e4e4b7ec52bad4702b1516eb1

Issues

Description	From	Last Updated
Should this be added now?	QuLogic	Nov. 1, 2024, 4:50 a.m.
Should this be removed now?	QuLogic	Nov. 1, 2024, 4:50 a.m.

Change Summary:: minor typo fix
Summary:: Rename Purple.Conversationmanager.register/unregister to add/remove
Rename Purple.ConversationManager.register/unregister to add/remove

libpurple/purpleconversationmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should this be added now?
```
libpurple/purpleconversationmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should this be removed now?
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Rename Purple.Conversationmanager.register/unregister to add/remove I also cleaned up some legacy work arounds that were missed then conversations were no longer auto added to the conversation manager.	260ec59ad99b82c8517ab73dba28d33c26959a30
	Rename Purple.Conversationmanager.register/unregister to add/remove I also cleaned up some legacy work arounds that were missed then conversations were no longer auto added to the conversation manager.	2ae1bf0c87fc404e4e4b7ec52bad4702b1516eb1

Diff:

Revision 2 (+340 -188)

	libpurple/purpleconversationmanager.h
	libpurple/purpleconversationmanager.c
	libpurple/tests/test_conversation_manager.c
	libpurple/tests/test_history_adapter.c
	libpurple/tests/test_history_manager.c

Ship it!