Summary

Implement Purple.CommandManager

Review Request #3619 — Created Oct. 30, 2024 and submitted Nov. 4, 2024, 9:13 p.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This ended up deviating from the design a bit, but I think I got everything we
need at least for now.

Testing Done

Ran the tests under valgrind and called in the turtles for the rest. Also ran in a devenv to make sure everything started fine.

Commits

Summary	ID
Implement Purple.CommandManager This ended up deviating from the design a bit, but I think I got everything we need at least for now.	ee14efdddeac58f064cb5379ae53f487c8b940ed

Issues

Description	From	Last Updated
I debated on making the command transfer full. Any thoughts?	grim	Nov. 3, 2024, 1:33 a.m.
Could throw in an "is" here, I think.	ivanhoe	Nov. 4, 2024, 9:11 p.m.
Missing "add"?	ivanhoe	Nov. 4, 2024, 9:12 p.m.
One "different" seems enough but I think there could be a "with" after the "but".	ivanhoe	Nov. 4, 2024, 9:12 p.m.

libpurple/purplecommandmanager.h (Diff revision 1)
The issue has been resolved. Show all issues
```
I debated on making the command transfer full. Any thoughts?
```

Change Summary:

rebased and make _add_command transfer full.

Commits:

	Summary	ID
	Implement Purple.CommandManager This ended up deviating from the design a bit, but I think I got everything we need at least for now.	99bc7e489bb1ee56868db248cb0c20dc0cbb9ca9
	Implement Purple.CommandManager This ended up deviating from the design a bit, but I think I got everything we need at least for now.	1b197541bc3783461d6c757f0e14b8b9cf8f044c

Diff:

	libpurple/core.c
	libpurple/meson.build
	libpurple/purplecommand.h
	libpurple/purplecommand.c
	libpurple/purplecommandmanager.h
	libpurple/purplecommandmanager.c
	libpurple/purplecommandmanagerprivate.h
	libpurple/tests/meson.build
	1 more

Ship it!

```
Ship It!
```
libpurple/purplecommand.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Could throw in an "is" here, I think.
```
libpurple/tests/test_command_manager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing "add"?
```
libpurple/tests/test_command_manager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
One "different" seems enough but I think there could be a "with" after the "but".
```

Change Summary:

Rebased and addressed issues.

Commits:

	Summary	ID
	Implement Purple.CommandManager This ended up deviating from the design a bit, but I think I got everything we need at least for now.	1b197541bc3783461d6c757f0e14b8b9cf8f044c
	Implement Purple.CommandManager This ended up deviating from the design a bit, but I think I got everything we need at least for now.	ee14efdddeac58f064cb5379ae53f487c8b940ed

Diff:

	libpurple/core.c
	libpurple/meson.build
	libpurple/purplecommand.h
	libpurple/purplecommand.c
	libpurple/purplecommandmanager.h
	libpurple/purplecommandmanager.c
	libpurple/purplecommandmanagerprivate.h
	libpurple/tests/meson.build
	1 more

libpurple/purplecommand.h (Diff revision 2)