Summary

IRCv3: Create notifications for incoming WALLOPS messages

Review Request #3611 — Created Oct. 28, 2024 and submitted Oct. 31, 2024, 11:54 p.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

IRCv3: Create notifications for incoming WALLOPS messages

Testing Done

Setup an inspricd instance and sent WALLOPS from there to test.

Commits

Summary	ID
Create notifications for incoming WALLOPS messages	f89c45f62e82abb9eb8ace38bdbe13c9b21bc045

Issues

Description	From	Last Updated
Should be %u	QuLogic	Oct. 31, 2024, 11:49 p.m.
Isn't there only 1 thing in params? wallops_message should be equal to params[0].	QuLogic	Oct. 31, 2024, 11:49 p.m.

Summary:: Create notifications for incoming WALLOPS messages
IRCv3: Create notifications for incoming WALLOPS messages
Description:: ~
Create notifications for incoming WALLOPS messages
~
IRCv3: Create notifications for incoming WALLOPS messages

protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should be %u
```
protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Isn't there only 1 thing in params? wallops_message should be equal to params[0].
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Create notifications for incoming WALLOPS messages	28b22ef33c2d2efdb6e7ace96cd8ab56da232cf3
	Create notifications for incoming WALLOPS messages	c32a05456f742642f71896a788ad9291b5f7440e

Diff:

	protocols/ircv3/purpleircv3connection.c
	protocols/ircv3/purpleircv3core.h
	protocols/ircv3/purpleircv3messagehandlers.h
	protocols/ircv3/purpleircv3messagehandlers.c
	protocols/ircv3/purpleircv3protocol.c

Ship it!

Change Summary:

rebased

Commits:

	Summary	ID
	Create notifications for incoming WALLOPS messages	c32a05456f742642f71896a788ad9291b5f7440e
	Create notifications for incoming WALLOPS messages	f89c45f62e82abb9eb8ace38bdbe13c9b21bc045

Diff:

	protocols/ircv3/purpleircv3connection.c
	protocols/ircv3/purpleircv3core.h
	protocols/ircv3/purpleircv3messagehandlers.h
	protocols/ircv3/purpleircv3messagehandlers.c
	protocols/ircv3/purpleircv3protocol.c