Summary

Add an argument to ibis-client for a list of channels to join

Review Request #3606 — Created Oct. 19, 2024 and submitted Nov. 10, 2024, 10:20 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-40

Depends On

Reviewers

Groups

pidgin

People

Description

I also plugged a bunch of memory leaks around the command line arguments and
reordered them as well.

Testing Done

Connected to a local ergo server and verified it joined the channels correctly.

Commits

Summary	ID
Add an argument to ibis-client for a list of channels to join I also plugged a bunch of memory leaks around the command line arguments and reordered them as well.	ce6882d55af1f888183d82e45b4c5a7b70d79ed1

Issues

Description	From	Last Updated
Should this be G_OPTION_ARG_STRING_ARRAY?	QuLogic	Nov. 10, 2024, 10:18 a.m.

ibis-cli/ibiscli.c (Diff revision 1)

The issue has been dropped. Show all issues

Should this be G_OPTION_ARG_STRING_ARRAY?

grim Oct. 20, 2024, 4:23 a.m.

We could do that, but since RFC 1459 you and do JOIN #channel1,#channel2,etc we're just pasing in whatever the user gives us to the join command which means they can technically join password protected channel too if they form it right. For example, say channel 1 requires a password of abc123 if they pass --join-channels "#channel1,#channel2 abc123 they'll join both channels successfully.

Ship it!

```
Ship It!
```

Status:: Completed