Summary

Add a require-sasl command line argument to the cli

Review Request #3601 — Created Oct. 18, 2024 and submitted Oct. 18, 2024, 7:13 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

~~3600~~

Reviewers

Groups

pidgin

People

Description

This is a work around and a feature, as we shouldn't enable SASL unless
explictly told because you can't disable it by setting the mechanisms to an
empty string if the server advertises any mechanisms.

This is working around a bug in either hasl or ibis, where the external
mechanism isn't responding. I created IBIS-39 to track that.

Testing Done

Connected to a local ergo with and without --sasl-required.

Commits

Summary	ID
Add a require-sasl command line argument to the cli This is a work around and a feature, as we shouldn't enable SASL unless explictly told because you can't disable it by setting the mechanisms to an empty string if the server advertises any mechanisms. This is working around a bug in either hasl or ibis, where the external mechanism isn't responding. I created IBIS-39 to track that.	0a5825a2d3f9b973322bcdbba1882a5a8d51a8a2

Issues

Description	From	Last Updated
Should this go in the if as well, or is setting it to NULL (redundant but) fine?	QuLogic	Oct. 18, 2024, 7:12 a.m.

ibis-cli/ibiscli.c (Diff revision 1)

The issue has been resolved. Show all issues

Should this go in the if as well, or is setting it to NULL (redundant but) fine?

grim Oct. 18, 2024, 7:06 a.m.

Yeah it's redundant but fine, as it just disabling sasl.

Change Summary:

rescope the hasl context.

Commits:

	Summary	ID
	Add a require-sasl command line argument to the cli This is a work around and a feature, as we shouldn't enable SASL unless explictly told because you can't disable it by setting the mechanisms to an empty string if the server advertises any mechanisms. This is working around a bug in either hasl or ibis, where the external mechanism isn't responding. I created IBIS-39 to track that.	4a7b724bcdb5cfb1a73f4001e9ea70125a3333d4
	Add a require-sasl command line argument to the cli This is a work around and a feature, as we shouldn't enable SASL unless explictly told because you can't disable it by setting the mechanisms to an empty string if the server advertises any mechanisms. This is working around a bug in either hasl or ibis, where the external mechanism isn't responding. I created IBIS-39 to track that.	0a5825a2d3f9b973322bcdbba1882a5a8d51a8a2

Diff:

Revision 2 (+46 -32)

Show changes

ibis-cli/ibiscli.c

Ship it!

```
Ship It!
```

Status:: Completed