Summary

Add constants for some server replies we were missing

Review Request #3581 — Created Oct. 15, 2024 and submitted Oct. 15, 2024, 1:36 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-37

Depends On

Reviewers

Groups

pidgin

People

Description

Add constants for some server replies we were missing

Testing Done

Called in the turtles.

Commits

Summary	ID
Add constants for some server replies we were missing	0c7d77e95a96434630824b84ac32d2d6b523d24c

Issues

Description	From	Last Updated
I don't see these on https://modern.ircdocs.horse/; is there a different reference?	QuLogic	Oct. 15, 2024, 1:35 a.m.
0.9	QuLogic	Oct. 15, 2024, 1:21 a.m.
0.9	QuLogic	Oct. 15, 2024, 1:21 a.m.
This one's maybe a bit weird as it seems to also be RPL_STATSDLINE in RFC2812? That appears to have been …	QuLogic	Oct. 15, 2024, 1:35 a.m.

The issue has been resolved. Show all issues

I don't see these on https://modern.ircdocs.horse/; is there a different reference?

grim Oct. 15, 2024, 1:10 a.m.

They're not part of the modern spec, but are legacy and are listed here, I can add a link if we like.

QuLogic Oct. 15, 2024, 1:22 a.m.

Ah, okay, maybe just mention that they're legacy replies? Then maybe link it once at the start or somewhere.

ibis/ibisversion.h (Diff revision 1)
The issue has been resolved. Show all issues
```
0.9
```
ibis/ibisversion.h (Diff revision 1)
The issue has been resolved. Show all issues
```
0.9
```

Change Summary:

Address version issues

Commits:

	Summary	ID
	Add constants for some server replies we were missing	fc48ccdf5a7660eabee3ac641c9994ad544c5c09
	Add constants for some server replies we were missing	c70b82210881a74fafd956439abb86995f1b8509

Diff:

Revision 2 (+106 -2)

Show changes

	meson.build
	ibis/ibisconstants.h
	ibis/ibisversion.h

ibis/ibisconstants.h (Diff revision 2)

The issue has been dropped. Show all issues

This one's maybe a bit weird as it seems to also be RPL_STATSDLINE in RFC2812? That appears to have been legacy at that point too, though.

grim Oct. 15, 2024, 1:28 a.m.

We could add a RPL_STATSDLINE too. But as you mentioned those are all kind of legacy.

Change Summary:

Add links to the documentation

Commits:

	Summary	ID
	Add constants for some server replies we were missing	c70b82210881a74fafd956439abb86995f1b8509
	Add constants for some server replies we were missing	0c7d77e95a96434630824b84ac32d2d6b523d24c

Diff:

Revision 3 (+130 -2)

Show changes

	meson.build
	ibis/ibisconstants.h
	ibis/ibisversion.h

Ship it!

```
Ship It!
```

Status:: Completed