Summary

Port network settings to GSettings

Review Request #3573 — Created Oct. 15, 2024 and submitted Oct. 15, 2024, 5:04 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Port network settings to GSettings

Testing Done

Changed all network settings in Preferences, and confirmed they all showed up in pidgin3.ini.

Commits

Summary	ID
Port network settings to GSettings	e78c08f95ba4850f068c4d767c90d0b21fc20a32

Issues

Description	From	Last Updated
Should this be (transfer full) now?	grim	Oct. 15, 2024, 5:03 a.m.

libpurple/network.h (Diff revision 1)

The issue has been dropped. Show all issues

Should this be (transfer full) now?

QuLogic Oct. 15, 2024, 5 a.m.

Yes, g_settings_get_string returns a new string now, so this needs to too.
If you mean a docs annotation, that's the default for char* (vs. transfer none for const char*), so I don't usually add those.

grim Oct. 15, 2024, 5:03 a.m.

Oh cool, I didn't realize that was the default.

Ship it!

```
Great work, thanks!
```

Status:: Completed