Create Purple.NotificationConnectionError

Review Request #3554 — Created Oct. 1, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

This is used to notify about connection errors.

Unit tests were skipped as we will be moving away to GError instead of
Purple.ConnectionErrorInfo, and writing the tests the old way would have just
meant more stuff to change later.

Reaped a connection with the demo protocol plugin and ran the notification manager tests under valgrind. And of course called in the turtles for a pizza party.

Summary ID
Create Purple.NotificationConnectionError
This is used to notify about connection errors. Unit tests were skipped as we will be moving away to GError instead of Purple.ConnectionErrorInfo, and writing the tests the old way would have just meant more stuff to change later.
f6dde943ec3494877ee8e6795a82ce228b7bca05
Description From Last Updated

If the account property changed, the this would be the wrong account to disconnect, wouldn't it?

QuLogicQuLogic

This doesn't appear to be true.

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/purplenotificationconnectionerror.c (Diff revision 1)
     
     
     
     
    Show all issues

    If the account property changed, the this would be the wrong account to disconnect, wouldn't it?

  3. Show all issues

    This doesn't appear to be true.

  4. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed