Create Pidgin.NotificationAuthorizationRequest

Review Request #3514 — Created Sept. 20, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

Create Pidgin.NotificationAuthorizationRequest

Tested on top of /r/3506 by using the authorization requests in the Demo protocol plugin.

Summary ID
Create Pidgin.NotificationAuthorizationRequest
0ff8b619844ccefc8549ea711b985bcfa86645eb
ivanhoe
  1. 
      
  2. Does this need to be rebased maybe? I can't apply the patch on top of f80f044d734c which should contain the changes of /r/3506.

    $ rbt patch 3514
    Applying 1 patch from review request 3514 (diff revision None)
    
    applying /tmp/rbtools.4n6_pknf
    patching file pidgin/meson.build
    Hunk #1 FAILED at 33
    Hunk #2 FAILED at 80
    2 out of 2 hunks FAILED -- saving rejects to file pidgin/meson.build.rej
    patching file pidgin/pidginnotificationlist.c
    Hunk #1 FAILED at 28
    Hunk #2 FAILED at 104
    2 out of 2 hunks FAILED -- saving rejects to file pidgin/pidginnotificationlist.c.rej
    patching file pidgin/resources/pidgin.gresource.xml
    Hunk #1 FAILED at 36
    1 out of 1 hunks FAILED -- saving rejects to file pidgin/resources/pidgin.gresource.xml.rej
    abort: patch failed to apply
    
    
    ERROR: Unable to apply the patch. The patch may be invalid, or there may be conflicts that could not be resolved.
    
    1. Yep, sorry about that.

  3. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed