Summary

Update Purple.AuthorizationRequest to use Purple.Contact

Review Request #3484 — Created Sept. 14, 2024 and submitted Sept. 17, 2024, 1 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3480~~

Groups

People

Description

This also required updating Purple.NotificationAuthorizationRequest.

Testing Done

Ran the authorization_request and notification_authorization_request tests under valgrind and called in the turtles for good measure.

Commits

Summary	ID
Update Purple.AuthorizationRequest to use Purple.Contact This also required updating Purple.NotificationAuthorizationRequest.	a195619fa5c44be59a2ddec68612c6480c172653

Issues

Description	From	Last Updated
account can be finalized too (and everywhere else if so)?	QuLogic	Sept. 17, 2024, 12:40 a.m.

libpurple/tests/test_authorization_request.c (Diff revision 1)
The issue has been resolved. Show all issues
```
account can be finalized too (and everywhere else if so)?
```

Change Summary:

rebase and use g_assert_finalize_object on accounts which works finally!

Commits:

	Summary	ID
	Update Purple.AuthorizationRequest to use Purple.Contact This also required updating Purple.NotificationAuthorizationRequest.	9bb73a3b9b20726e16337136e78cf220b404d775
	Update Purple.AuthorizationRequest to use Purple.Contact This also required updating Purple.NotificationAuthorizationRequest.	a195619fa5c44be59a2ddec68612c6480c172653

Diff:

Revision 2 (+298 -524)

	libpurple/purpleauthorizationrequest.h
	libpurple/purpleauthorizationrequest.c
	libpurple/purplenotificationauthorizationrequest.c
	libpurple/tests/test_authorization_request.c
	libpurple/tests/test_notification_authorization_request.c

Ship it!