Summary

Create Pidgin.Notification to simplify the custom widgets

Review Request #3480 — Created Sept. 13, 2024 and submitted Sept. 17, 2024, 5:58 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17929, PIDGIN-17942

Depends On

Blocks

3484

Reviewers

Groups

pidgin

People

Description

This should be much easier to maintain as it keeps everything encapsulated.

PidginNotificationAuthorizationRequest was removed as nothing creates these
notifications right now.

PidginNotificationConnectionError was removed as we are currently in the
process of reworking the way connection errors work and this is in the way of
that.

Testing Done

Created a bunch of test notifications with the demo protocol plugin and called in the turtles.

Commits

Summary	ID
Create Pidgin.Notification to simplify the custom widgets This should be much easier to maintain as it keeps everything encapsulated. PidginNotificationAuthorizationRequest was removed as nothing creates these notifications right now. PidginNotificationConnectionError was removed as we are currently in the process of reworking the way connection errors work and this is in the way of that.	df4cc3285eff1efbd0cb89aa9898eded5735590e

Issues

Description	From	Last Updated
reserved	QuLogic	Sept. 17, 2024, 5:55 a.m.
purple_contact_create_dm_finish was transfer full, so conversation leaked here.	QuLogic	Sept. 17, 2024, 5:55 a.m.
Is PurpleNotification:title markup? It doesn't look like it's defined as such.	QuLogic	Sept. 17, 2024, 5:56 a.m.
Same for PurpleNotification:subtitle.	QuLogic	Sept. 17, 2024, 5:56 a.m.

Bugs:: PIDGIN-17929

pidgin/pidginnotification.h (Diff revision 1)
The issue has been resolved. Show all issues
```
reserved
```
pidgin/pidginnotificationaddcontact.c (Diff revision 1)
The issue has been resolved. Show all issues
```
purple_contact_create_dm_finish was transfer full, so conversation leaked here.
```
pidgin/resources/notification.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Is PurpleNotification:title markup? It doesn't look like it's defined as such.
```
pidgin/resources/notification.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Same for PurpleNotification:subtitle.
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Create Pidgin.Notification to simplify the custom widgets This should be much easier to maintain as it keeps everything encapsulated. PidginNotificationAuthorizationRequest was removed as nothing creates these notifications right now. PidginNotificationConnectionError was removed as we are currently in the process of reworking the way connection errors work and this is in the way of that.	0bf52e85b83689dacbe1daecd60efa2417751df7
	Create Pidgin.Notification to simplify the custom widgets This should be much easier to maintain as it keeps everything encapsulated. PidginNotificationAuthorizationRequest was removed as nothing creates these notifications right now. PidginNotificationConnectionError was removed as we are currently in the process of reworking the way connection errors work and this is in the way of that.	df4cc3285eff1efbd0cb89aa9898eded5735590e

Diff:

Revision 2 (+1166 -2632)

Show changes

	pidgin/meson.build
	pidgin/pidginnotification.h
	pidgin/pidginnotification.c
	pidgin/pidginnotificationaddcontact.h
	pidgin/pidginnotificationaddcontact.c
	pidgin/pidginnotificationauthorizationrequest.h
	pidgin/pidginnotificationauthorizationrequest.c
	pidgin/pidginnotificationconnectionerror.h
	7 more

Ship it!

```
Ship It!
```

Status:: Completed

pidgin/pidginnotification.h (Diff revision 1)