Display CTCP requests in the status window

 






 

 


  Review Request #3470
  —
  Created Sept. 6, 2024 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  PIDGIN-17893
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
In the future we might show this in conversations if they exist, but for now
this gets the job done. The content of the message is the same thing we
displayed in Pidgin 2.

 








  


 
 

  
Connected to my local ergo and sent CTCP messages from pidgin 2 and irssi to my pidgin 3 instance and a channel.


Also called in the turtles for good measure.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Display CTCP requests in the status window
      
In the future we might show this in conversations if they exist, but for now
this gets the job done. The content of the message is the same thing we
displayed in Pidgin 2.

     


    		
    8b7aece1167f656b0a85233b23f9204297194d27

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Why change this line?

      		
      
       QuLogicQuLogic
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       protocols/ircv3/purpleircv3messagehandlers.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Why change this line?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      It felt cleaner at the time. Like we're setting the default value of target to params[0] but in this method we change it, so using it felt weird..
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I guess it makes more sense to me as:
      

      target = something;
if (target is invalid) {
    target = some other thing;
}

      

      or
      

      if (something is valid) {
    target = something;
} else {
    target = some other thing.
}

      

      but this is now sort of in between.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      The first one makes sense. I'll fix it here in a second.
      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed