Summary

Implement standard replies

Review Request #3460 — Created Sept. 1, 2024 and submitted Sept. 3, 2024, 8 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-13

Depends On

~~3458~~

Reviewers

Groups

pidgin

People

Description

This introduces Ibis.StandardReply and exposes it via Ibis.Message if a
standard reply could be parsed from that message.

Testing Done

Ran the message and standard_reply tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Implement standard replies This introduces Ibis.StandardReply and exposes it via Ibis.Message if a standard reply could be parsed from that message.	73a82e3d8981109fb8aa011a565326b1a12d13c2

Issues

Description	From	Last Updated
Note, you can wrap markdown links in the middle of the description; this fits into 80 characters: * See [standard …	QuLogic	Sept. 3, 2024, 7:20 a.m.
This sorts after NOTE?	QuLogic	Sept. 3, 2024, 7:20 a.m.
parsed	QuLogic	Sept. 3, 2024, 6:39 a.m.
reply_type wasn't initialized to NULL.	QuLogic	Sept. 3, 2024, 6:39 a.m.
It appears there are no tests that trigger failures / a NULL return from parsing?	QuLogic	Sept. 3, 2024, 6:41 a.m.

ibis/ibisconstants.h (Diff revision 1)

The issue has been resolved. Show all issues

Note, you can wrap markdown links in the middle of the description; this fits into 80 characters:

 * See [standard replies message
 * format](https://ircv3.net/specs/extensions/standard-replies#message-format)
 * for more information.

QuLogic Sept. 3, 2024, 6:39 a.m.

I didn't mark it, but the other two can wrap as well.

grim Sept. 3, 2024, 7:11 a.m.
```
Whoops
```

ibis/ibisconstants.h (Diff revision 1)

The issue has been resolved. Show all issues

This sorts after NOTE?

grim Sept. 3, 2024, 6:16 a.m.

They're sorted asciibetically in the source not prescendence.

QuLogic Sept. 3, 2024, 6:38 a.m.
```
Yes, I mean asciibetically.
```

grim Sept. 3, 2024, 7:11 a.m.

My bad, I thought I got this right everywhere and didn't look at additional context..

ibis/ibismessage.c (Diff revision 1)
The issue has been resolved. Show all issues
```
parsed
```
ibis/ibisstandardreply.c (Diff revision 1)
The issue has been resolved. Show all issues
```
reply_type wasn't initialized to NULL.
```

ibis/tests/test_standard_reply.c (Diff revision 1)

The issue has been resolved. Show all issues

It appears there are no tests that trigger failures / a NULL return from parsing?

Change Summary:

rebased and address issues.

Commits:

	Summary	ID
	Implement standard replies This introduces Ibis.StandardReply and exposes it via Ibis.Message if a standard reply could be parsed from that message.	3230fddab04434a3fb3ba1af9596f15bdc43a0b6
	Implement standard replies This introduces Ibis.StandardReply and exposes it via Ibis.Message if a standard reply could be parsed from that message.	8c642d79b42c5c14c819f933f4988c14bdcdcd76

Diff:

Revision 2 (+1636)

Show changes

	ibis/ibisconstants.h
	ibis/ibismessage.h
	ibis/ibismessage.c
	ibis/ibisstandardreply.h
	ibis/ibisstandardreply.c
	ibis/meson.build
	ibis/tests/meson.build
	ibis/tests/test_standard_reply.c

Change Summary:

Address issues.

Commits:

	Summary	ID
	Implement standard replies This introduces Ibis.StandardReply and exposes it via Ibis.Message if a standard reply could be parsed from that message.	8c642d79b42c5c14c819f933f4988c14bdcdcd76
	Implement standard replies This introduces Ibis.StandardReply and exposes it via Ibis.Message if a standard reply could be parsed from that message.	73a82e3d8981109fb8aa011a565326b1a12d13c2

Diff:

Revision 3 (+1634)

Show changes

	ibis/ibisconstants.h
	ibis/ibismessage.h
	ibis/ibismessage.c
	ibis/ibisstandardreply.h
	ibis/ibisstandardreply.c
	ibis/meson.build
	ibis/tests/meson.build
	ibis/tests/test_standard_reply.c

Ship it!

```
Ship It!
```

Status:: Completed