Summary

Add synthetic features for the parsed values of the PREFIX feature

Review Request #3459 — Created Sept. 1, 2024 and submitted Sept. 5, 2024, 9:11 p.m.

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

~~3458~~

Groups

People

Description

Also did quite a few simple drive-bys.

Testing Done

Ran the features tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Add synthetic features for the parsed values of the PREFIX feature	d774d20198f6a56776e7c90393a019169c861673

Issues

Description	From	Last Updated
No tests for this not matching? Is that caught by an overall regex earlier?	QuLogic	Sept. 5, 2024, 8:57 p.m.
s/an/a/ or s/an/any/	QuLogic	Sept. 5, 2024, 8:55 p.m.
s/an/a/ or s/an/any/	QuLogic	Sept. 5, 2024, 8:55 p.m.
features	QuLogic	Sept. 5, 2024, 8:56 p.m.

ibis/ibisfeatures.c (Diff revision 1)

The issue has been resolved. Show all issues

No tests for this not matching? Is that caught by an overall regex earlier?

ibis/ibisfeatures.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/an/a/ or s/an/any/
```
ibis/ibisfeatures.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/an/a/ or s/an/any/
```
ibis/tests/test_features.c (Diff revision 1)
The issue has been resolved. Show all issues
```
features
```

Change Summary:

Addressed issues and added more unit tests

Commits:

	Summary	ID
	Add synthetic features for the parsed values of the PREFIX feature	788920c5b7a9c11f357f268dd6bd911b2c0a05fe
	Add synthetic features for the parsed values of the PREFIX feature	d774d20198f6a56776e7c90393a019169c861673

Diff:

Revision 2 (+358 -24)

Ship it!