Summary

Add Ibis.source_get_prefix and Ibis.source_strip_prefix

Review Request #3458 — Created Sept. 1, 2024 and submitted Sept. 3, 2024, 7:58 a.m.

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Blocks

Groups

People

Description

Add Ibis.source_get_prefix and Ibis.source_strip_prefix

Testing Done

Ran the source tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Add Ibis.source_get_prefix and Ibis.source_strip_prefix	efaddb319116b71108ed8d66de6445c2e52cf93e

Issues

Description	From	Last Updated
May be redundant since this is static and all callers check.	QuLogic	Sept. 3, 2024, 7:40 a.m.
This priority thing maybe should be mentioned in the docs for the functions.	QuLogic	Sept. 3, 2024, 7:39 a.m.
This probably could be just source[source_offset] == '\0' to avoid the strlen.	QuLogic	Sept. 3, 2024, 7:39 a.m.
This probably conflicts since we have 0.7.1 now.	QuLogic	Sept. 3, 2024, 7:38 a.m.

ibis/ibissource.c (Diff revision 1)

The issue has been dropped. Show all issues

May be redundant since this is static and all callers check.

Yeah it was just me being defensive. I can go either way on keeping them.

ibis/ibissource.c (Diff revision 1)

The issue has been resolved. Show all issues

This priority thing maybe should be mentioned in the docs for the functions.

ibis/ibissource.c (Diff revision 1)

The issue has been resolved. Show all issues

This probably could be just source[source_offset] == '\0' to avoid the strlen.

meson.build (Diff revision 1)
The issue has been resolved. Show all issues
```
This probably conflicts since we have 0.7.1 now.
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Add Ibis.source_get_prefix and Ibis.source_strip_prefix	19076ac4ad5c6fe5eff68007a5925769e432579f
	Add Ibis.source_get_prefix and Ibis.source_strip_prefix	efaddb319116b71108ed8d66de6445c2e52cf93e

Diff:

Ship it!