Summary

Implement Purple.Badges

Review Request #3451 — Created Aug. 31, 2024 and submitted Sept. 3, 2024, 5:34 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Implement Purple.Badges

Testing Done

Ran the unit tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Implement Purple.Badges	6997ab2c32d970157293ddc5fa0267ca44e36f81

Issues

Description	From	Last Updated
Is it necessary to sort the array again? From what I understand g_ptr_array_remove_index should preserve the order of the array.	ivanhoe	Sept. 3, 2024, 4:56 a.m.
Shouldn't this be adapted if we're not sorting?	ivanhoe	Sept. 3, 2024, 5:23 a.m.
s/other/otherwise	ivanhoe	Sept. 3, 2024, 4:56 a.m.
s/them/then	ivanhoe	Sept. 3, 2024, 4:56 a.m.

libpurple/purplebadges.c (Diff revision 1)

The issue has been resolved. Show all issues

Is it necessary to sort the array again? From what I understand g_ptr_array_remove_index should preserve the order of the array.

libpurple/purplebadges.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/other/otherwise
```
libpurple/tests/test_badges.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/them/then
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Implement Purple.Badges	71c816bbae70ddb5168698f89a4f08499db670a3
	Implement Purple.Badges	df0b6d1404de170550906e1cf240310af00ff381

Diff:

	libpurple/meson.build
	libpurple/purplebadges.h
	libpurple/purplebadges.c
	libpurple/tests/meson.build
	libpurple/tests/test_badges.c

libpurple/purplebadges.c (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Shouldn't this be adapted if we're not sorting?
```

Change Summary:

Optimize the items-changed update as we no longer sort on remove.

Commits:

	Summary	ID
	Implement Purple.Badges	df0b6d1404de170550906e1cf240310af00ff381
	Implement Purple.Badges	6997ab2c32d970157293ddc5fa0267ca44e36f81

Diff:

	libpurple/meson.build
	libpurple/purplebadges.h
	libpurple/purplebadges.c
	libpurple/tests/meson.build
	libpurple/tests/test_badges.c

Ship it!