Summary

Update Purple.AddContactRequest to use a PurpleContact

Review Request #3446 — Created Aug. 27, 2024 and submitted Aug. 28, 2024, 6:02 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Previous this was using an account, username, and alias, all of which exist in
PurpleContact.

Testing Done

Called in the turtles and used the add contact action in the demo protocol plugin.

Commits

Summary	ID
Update Purple.AddContactRequest to use a PurpleContact Previous this was using an account, username, and alias, all of which exist in PurpleContact.	5d5a979ed5a5ff88ce6a812fcd2943d33adf02e7

Issues

Description	From	Last Updated
Purple: purple_add_contact_request_get_contact: return value: Missing (transfer) annotation	ivanhoe	Aug. 28, 2024, 5:18 a.m.
Could make this a char.	ivanhoe	Aug. 28, 2024, 5:18 a.m.

libpurple/purpleaddcontactrequest.h (Diff revision 1)

The issue has been resolved. Show all issues

Purple: purple_add_contact_request_get_contact: return value: Missing (transfer) annotation

protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Could make this a char.
```

Change Summary:

rebased, addressed issues and did a few more cleanups in demoprotocolactions

Commits:

	Summary	ID
	Update Purple.AddContactRequest to use a PurpleContact Previous this was using an account, username, and alias, all of which exist in PurpleContact.	35a6dbae67854a07f2fa6212481b7602c3a70481
	Update Purple.AddContactRequest to use a PurpleContact Previous this was using an account, username, and alias, all of which exist in PurpleContact.	5d5a979ed5a5ff88ce6a812fcd2943d33adf02e7

Diff:

Revision 2 (+118 -410)

	libpurple/purpleaddcontactrequest.h
	libpurple/purpleaddcontactrequest.c
	libpurple/purplenotification.c
	pidgin/pidginnotificationaddcontact.c
	protocols/demo/purpledemoprotocolactions.c

Ship it!