Fish Trophy

grim got a fish trophy!

Fish Trophy

Add all XDG Base Dir values to the devenv

Review Request #3443 — Created Aug. 26, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

Add all XDG Base Dir values to the devenv

Ran under the devenv without any new issues.

Summary ID
Add all XDG Base Dir values to the devenv
5e7fa38bf9d4c39089565b5dc12fea815e0bc340
ivanhoe
  1. 
      
  2. While you're at it. It would be nice to have something like devenv.append('XDG_DATA_DIRS', '/usr/share') there as well.

    I always need to do export XDG_DATA_DIRS=$XDG_DATA_DIRS:/usr/share otherwise Pidgin either crashes or at the very least does not use the system icons.

    1. Is this a new crash? I haven't seen this before myself.

    2. It's not new. I think I'm the only one getting it, might be related to me running KDE.

    3. Interesting. I'm hesistant to start throwing tons of stuff in there, but it probably won't hurt.. The tons of stuff would be because of macOS and Windows mostly, but we can cross that bridge when we need to.

    4. Per the spec, it should default to /usr/local/share/:/usr/share/ which we can see is set properly in glib as you can see here https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gutils.c#L2696.

  3. 
      
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed