Use Purple.Account.username in cases where Purple.ContactInfo.name_for_display is NULL

 






 

 


  Review Request #3431
  —
  Created Aug. 22, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  ivanhoe
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This solves the following situations where an account name was displayed as "(null)":
* in the confirmation dialog, when removing an account from the account manager
* in the account combo box in the join channel dialog

 








  


 
 

  
Removed an account from the account manager and verified that the account name was not "(null)" in the confirmation dialog.

Opened the Join Channel dialog with a connected IRC account and verfied that the account name was not "(null)".

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Set Purple.Account.contact_info.username when constructing an account

   
  		
  4946dd45817e44ee64266167b5df789263ba1200
  Markus Fischer
 


 
  
 
 
  
   
    
Use Purple.Account.username in cases where Purple.ContactInfo.name_for_displa...

   
  		
  c4b4d197ba45a9deeca78024a0b9d63984fa4beb
  Markus Fischer
 




    


    
    

   

  

 









 

  

   
    

     
      
      libpurple/purpleaccount.c
     
    

   
  

 



 

  

   
    

     
      
      pidgin/pidginaccountmanagerrow.c
     
    

   
  

 



 

  

   
    

     
      
      pidgin/resources/Accounts/display.ui
     
    

   
  

 










     

    

   

  

  

   
   Loading...