Use Purple.Account.username in cases where Purple.ContactInfo.name_for_display is NULL
Review Request #3431 — Created Aug. 22, 2024 and submitted
This solves the following situations where an account name was displayed as "(null)": * in the confirmation dialog, when removing an account from the account manager * in the account combo box in the join channel dialog
Removed an account from the account manager and verified that the account name was not "(null)" in the confirmation dialog.
Opened the Join Channel dialog with a connected IRC account and verfied that the account name was not "(null)".
| Summary | ID |
|---|---|
| c4b4d197ba45a9deeca78024a0b9d63984fa4beb |
- Change Summary:
-
Redid the whole RR (see Description).
- Summary:
-
Set Purple.Account.contact_info.username when constructing an accountUse Purple.Account.username in cases where Purple.ContactInfo.name_for_display is NULL
- Description:
-
~ This solves the problem that Purple.ContactInfo.get_name_for_display returns
NULLon some occasions. For example, when removing an account from the account manager.~ This solves the following situations where an account name was displayed as "(null)":
+ * in the confirmation dialog, when removing an account from the account manager + * in the account combo box in the join channel dialog - Testing Done:
-
~ Removed an account from the account manager and verified that the account name was not "(null)" in the confirmation dialog.
~ Removed an account from the account manager and verified that the account name was not "(null)" in the confirmation dialog.
+ Opened the Join Channel dialog with a connected IRC account and verfied that the account name was not "(null)". - Commits:
-
Summary ID 4946dd45817e44ee64266167b5df789263ba1200 c4b4d197ba45a9deeca78024a0b9d63984fa4beb