Summary

Update Purple.Message to use the Purple.ContactInfo

Review Request #3427 — Created Aug. 21, 2024 and submitted Aug. 23, 2024, 6:11 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17902

Depends On

~~3429~~, ~~3428~~

Reviewers

Groups

pidgin

People

Description

This deprecates the author-alias and author-name properties and makes them
read only. Those properties also had to be removed from the unit tests as I
was unable to stop the deprecation warning happening at run time which was
causing the tests to fail.

Testing Done

Ran the message and conversation tests under valgrind and called in the turtles.

Commits

Summary	ID
Update Purple.Message to use the Purple.ContactInfo This deprecates the author-alias and author-name properties and makes them read only.	a9136ff15b0fc1c114f8e61a41287fd1669eccf5

Issues

Description	From	Last Updated
Shouldn't this also say that it's deprecated?	ivanhoe	Aug. 23, 2024, 6:09 a.m.

Depends On:: ~~3429 - Update libpurple to use Purple.Message.new~~

Depends On:: ~~3428 - IRCv3: Use Purple.Message.new instead of GObject.new~~

libpurple/purplemessage.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Shouldn't this also say that it's deprecated?
```

Change Summary:

rebased and addressed the issue.

Commits:

	Summary	ID
	Update Purple.Message to use the Purple.ContactInfo This deprecates the author-alias and author-name properties and makes them read only.	2039d9d293f36b97d2983b909fe7b4bc8bd9b0c4
	Update Purple.Message to use the Purple.ContactInfo This deprecates the author-alias and author-name properties and makes them read only.	a9136ff15b0fc1c114f8e61a41287fd1669eccf5

Diff:

Revision 2 (+112 -154)

Show changes

	libpurple/purplemessage.h
	libpurple/purplemessage.c
	libpurple/tests/test_conversation.c
	libpurple/tests/test_message.c

Ship it!

```
Ship It!
```

Status:: Completed

libpurple/purplemessage.c (Diff revision 1)