Summary

Break out Purple.Conversation:members to its own class

Review Request #3417 — Created Aug. 20, 2024 and submitted Aug. 20, 2024, 9:07 p.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

3418

Groups

People

Description

Break out Purple.Conversation:members to its own class

Testing Done

Ran the unit tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Break out Purple.Conversation:members to its own class	fbc7efa3f68072ad93048387eccfc3160abef361

Issues

Description	From	Last Updated
I think this should be just int now or guint? Same for lines 439 and 440.	ivanhoe	Aug. 20, 2024, 9:37 a.m.

Change Summary:

fix a bad signal link

Commits:

	Summary	ID
	Break out Purple.Conversation:members to its own class	54af62a893a75c33e5ba75260791da8202757036
	Break out Purple.Conversation:members to its own class	fbc7efa3f68072ad93048387eccfc3160abef361

Diff:

Revision 2 (+1486 -234)

	libpurple/meson.build
	libpurple/purpleconversationmembers.h
	libpurple/purpleconversationmembers.c
	libpurple/tests/meson.build
	libpurple/tests/test_conversation.c
	libpurple/tests/test_conversation_members.c

libpurple/tests/test_conversation.c (Diff revision 2)

The issue has been dropped. Show all issues

I think this should be just int now or guint? Same for lines 439 and 440.

You commented on the delete side with those line numbers and I think I fixed them all on the other side..?

Ship it!