Don't treat CTCP messages and params exclusively

Review Request #3407 — Created Aug. 15, 2024 and submitted

Information

ibis/ibis
default

Reviewers

The original CTCP implementation mistakenly ignored all parameters except the
last one that contained the CTCP data. This is wrong, as PRIVMSG and NOTICE
need at least 2 parameters, one for the target and the other for the data,
which in this case, was the CTCP body.

This updates the code and unit tests to check for all of this.

Ran the parser unit tests under valgrind and called in the turtles for the rest.

Summary ID
Don't treat CTCP messages and params exclusively
The original CTCP implementation mistakenly ignored all parameters except the last one that contained the CTCP data. This is wrong, as PRIVMSG and NOTICE need at least 2 parameters, one for the target and the other for the data, which in this case, was the CTCP body. This updates the code and unit tests to check for all of this.
9a74629a4b8910a970221ae003cad04d4f6ef4aa
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed