Add Features.client_tag_denied method

Review Request #3405 — Created Aug. 15, 2024 and submitted

Information

ibis/ibis
default

Reviewers

Add Features.client_tag_denied method

Ran the features unit test in valgrind.

Summary ID
Add Features.client_tag_denied method
85f09d5ad2ff12a8a022e5ddf36c365d2f562eb8
Description From Last Updated

There should be a newline between these two, otherwise the See line will show up in the summary on the …

grimgrim

The client-only prefix (+) is omitted when a tag appears in this list. Our contstants for tags include the + …

grimgrim

I've been using GStrv instead of char ** as it's a bit easier, I think, for others to follow.

grimgrim
grim
  1. 
      
  2. ibis/ibisfeatures.h (Diff revision 1)
     
     
    Show all issues

    There should be a newline between these two, otherwise the See line will show up in the summary on the method index page in the docs.

  3. ibis/ibisfeatures.c (Diff revision 1)
     
     
    Show all issues

    The client-only prefix (+) is omitted when a tag appears in this list.

    Our contstants for tags include the + prefix so that users don't need to care about it. With that fact and the above statement, we need to remove the + from the tag that the user passes in.

  4. ibis/ibisfeatures.c (Diff revision 1)
     
     
    Show all issues

    I've been using GStrv instead of char ** as it's a bit easier, I think, for others to follow.

  5. 
      
ivanhoe
grim
  1. Great work! Thank you so much!!

  2. 
      
grim
Review request changed
Status:
Completed