Summary

Modernize the Purple.ConversationMember tests

Review Request #3397 — Created Aug. 13, 2024 and submitted Aug. 13, 2024, 4:08 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This was really just to stop using GMainLoop but I added some additional
testing as well.

Testing Done

Ran the tests under valgrind.

Commits

Summary	ID
Modernize the Pruple.ConversationMember tests This was really just to stop using GMainLoop but I added some additional testing as well.	6249ff0b863b988ab971b0d0130f6e3d23fe3b92

Issues

Description	From	Last Updated
Since this is a (potentially) infinite loop if the timeout doesn't happen, I think we may still need the fail …	QuLogic	Aug. 13, 2024, 4:06 a.m.

Change Summary:: Fix typo
Summary:: Modernize the Pruple.ConversationMember tests
Modernize the Purple.ConversationMember tests

libpurple/tests/test_conversation_member.c (Diff revision 1)

The issue has been resolved. Show all issues

Since this is a (potentially) infinite loop if the timeout doesn't happen, I think we may still need the fail safe.

Change Summary:

Add a fail safe back in.

Commits:

	Summary	ID
	Modernize the Pruple.ConversationMember tests This was really just to stop using GMainLoop but I added some additional testing as well.	7d28da02c5a487a2fbf1125d3b31d7ba9dcfabea
	Modernize the Pruple.ConversationMember tests This was really just to stop using GMainLoop but I added some additional testing as well.	6249ff0b863b988ab971b0d0130f6e3d23fe3b92

Diff:

Ship it!