Summary

Remove Purple.ProtocolActions

Review Request #3396 — Created Aug. 13, 2024 and submitted Aug. 16, 2024, 4:14 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17884

Depends On

~~3395~~

Reviewers

Groups

pidgin

People

Description

Everything has been migrated to Purple.Protocol.get_action_menu except for the
actions-changed signal which we'll revisit when we are ready for it as I'm not
sure the current or previous setup would have actually worked.

Testing Done

Called in the turtles and verified the actions still work on the demo protocol plugin.

Commits

Summary	ID
Remove Purple.ProtocolActions Everything has been migrated to Purple.Protocol.get_action_menu except for the actions-changed signal which we'll revisit when we are ready for it as I'm not sure the current or previous setup would have actually worked.	84046b496755968a94bd28764fdf248b5effa864

Issues

Description	From	Last Updated
The signal is still used in pidgin_accounts_enabled_menu_init.	ivanhoe	Aug. 16, 2024, 3:50 a.m.

libpurple/purpleprotocolmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
The signal is still used in pidgin_accounts_enabled_menu_init.
```

Change Summary:

rebased and addressed the issues

Commits:

	Summary	ID
	Remove Purple.ProtocolActions Everything has been migrated to Purple.Protocol.get_action_menu except for the actions-changed signal which we'll revisit when we are ready for it as I'm not sure the current or previous setup would have actually worked.	5bcd72c48b3bf290ac86f730bf50847019380e09
	Remove Purple.ProtocolActions Everything has been migrated to Purple.Protocol.get_action_menu except for the actions-changed signal which we'll revisit when we are ready for it as I'm not sure the current or previous setup would have actually worked.	84046b496755968a94bd28764fdf248b5effa864

Diff:

Revision 2 (-656)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolactions.h
	libpurple/purpleprotocolactions.c
	libpurple/purpleprotocolcontacts.h
	libpurple/purpleprotocolmanager.c
	pidgin/pidginaccountsenabledmenu.c

Ship it!

```
Ship It!
```

Status:: Completed