Summary

Modernize the credential manager tests

Review Request #3370 — Created Aug. 8, 2024 and submitted Aug. 13, 2024, 2:32 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This mostly means using g_main_context_iteration rather than a full blown event
loop. There were also updates to the implementation to handle the core not
being initialized.

Testing Done

Ran the credential manager tests under valgrind, called in the turtles, and ran in the devenv, changed the provider, restarted and verified it was saved.

Commits

Summary	ID
Modernize the credential manager tests This mostly means using g_main_context_iteration rather than a full blown event loop. There were also updates to the implementation to handle the core not being initialized.	e62f00bf6d52d75878159fdef1c27ab22cd44c7b

Issues

Description	From	Last Updated
This probably conflicted with /r/3385.	QuLogic	Aug. 13, 2024, 2:20 a.m.
This is duplicated from above.	QuLogic	Aug. 13, 2024, 2:26 a.m.

libpurple/purplecredentialmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This probably conflicted with /r/3385.
```

Change Summary:

rebased and addressed conflicts.

Commits:

	Summary	ID
	Modernize the credential manager tests This mostly means using g_main_context_iteration rather than a full blown event loop. There were also updates to the implementation to handle the core not being initialized.	45207b701dd9d1be1b4ebf79174aba8dd61a4681
	Modernize the credential manager tests This mostly means using g_main_context_iteration rather than a full blown event loop. There were also updates to the implementation to handle the core not being initialized.	055777e212a4615e1fe0d8d5bef368a81dc4c547

Diff:

Revision 2 (+368 -608)

Show changes

	libpurple/purplecredentialmanager.c
	libpurple/tests/test_credential_manager.c

libpurple/purplecredentialmanager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
This is duplicated from above.
```

Change Summary:

rebased and removed duplicate code.

Commits:

	Summary	ID
	Modernize the credential manager tests This mostly means using g_main_context_iteration rather than a full blown event loop. There were also updates to the implementation to handle the core not being initialized.	055777e212a4615e1fe0d8d5bef368a81dc4c547
	Modernize the credential manager tests This mostly means using g_main_context_iteration rather than a full blown event loop. There were also updates to the implementation to handle the core not being initialized.	e62f00bf6d52d75878159fdef1c27ab22cd44c7b

Diff:

Revision 3 (+352 -608)

Show changes

libpurple/tests/test_credential_manager.c

Ship it!

```
Ship It!
```

Status:: Completed