Summary

Use a notification instead of purple_notify_error when the active credential provider can not be found

Review Request #3347 — Created Aug. 6, 2024 and submitted Aug. 6, 2024, 5:01 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Use a notification instead of purple_notify_error when the active credential provider can not be found

Testing Done

Changed the setting for the active credential provider to one that doesn't exist, and verified that the notification was displayed.

Commits

Summary	ID
Use a notification instead of purple_notify_error when the active credential provider can not be found	a1dce310abe391247a21ac9a39d747594d8ccb88

Issues

Description	From	Last Updated
Is this really useful as the title? I would put the "Failed to load..." text as the title, and the …	QuLogic	Aug. 6, 2024, 4:59 a.m.

libpurple/purplecredentialmanager.c (Diff revision 1)

The issue has been resolved. Show all issues

Is this really useful as the title?

I would put the "Failed to load..." text as the title, and the "Check your system ..." in the subtitle. The icon could be dialog-password possibly, though it's not really a dialog.

grim Aug. 6, 2024, 4:42 a.m.

That makes sense for the titles.

As for the icons, I'm not sure. I'm also thinking the ui should have a default icon maybe?

But I did open PIDGIN-17876 with the intent to have actions that could take you to the settings, but that's going to be a ways out.

Change Summary:

Rebased and cleaned up the title/subtitle

Commits:

	Summary	ID
	Use a notification instead of purple_notify_error when the active credential provider can not be found	860621d443f61c9ad8f79b167a5369ec905327c0
	Use a notification instead of purple_notify_error when the active credential provider can not be found	a1dce310abe391247a21ac9a39d747594d8ccb88

Diff:

Revision 2 (+36 -12)

Show changes

libpurple/purplecredentialmanager.c

Ship it!

```
Ship It!
```

Status:: Completed