Use birb_date_time_equal in birb_date_time_set

 






 

 


  Review Request #3313
  —
  Created July 28, 2024 and submitted 

 




















 

  

   Information

  





 
 

  ivanhoe
 









 
 

  birb/birb
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
I think it makes sense not to compare pointers here, but use birb_date_time_equal instead. So we can easily just call birb_date_time_set when setting GDateTime members.

 








  


 
 

  
Compiled and ran the date_time unit test in valgrind.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
Use birb_date_time_equal in birb_date_time_set


    		
    4b0549f015ac524ff0f9de8ebb8db6981589f0ef

   



  
 




 













 









 






  

 








 














 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Nice work, thanks!
    

    I believe the pointer check was mostly to handle nulls and simple cases, but this is by far a superior solution.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed