Summary

Mutliple cleanups to Purple.Message

Review Request #3289 — Created July 12, 2024 and submitted July 13, 2024, 1:28 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17869

Depends On

Reviewers

Groups

pidgin

People

Description

* Reorder a bunch stuff so it is alphabetical
* Added purple_message_new and deprecated the other constructors for it.
* Added a new author-name property and marked the author property as deprecated
  for it.
* Added new event and notice properties
* De-dented get_property and set_property
* Turned on warning for deprecated signals and properties in the devenv and
  purple unit tests.
* Added purple_message_set_timestamp_now to set the timestamp to utc now

Testing Done

Cowabunga'd with the turtles.
Sent some messages over dm and channels.

Commits

Summary	ID
Mutliple cleanups to Purple.Message * Reorder a bunch stuff so it is alphabetical * Added purple_message_new and deprecated the other constructors for it. * Added a new author-name property and marked the author property as deprecated for it. * Added new event and notice properties * De-dented get_property and set_property * Turned on warning for deprecated signals and properties in the devenv and purple unit tests. * Added purple_message_set_timestamp_now to set the timestamp to utc now	c5e01f2a91409fddd389d57d8cba1698b6fc2a2a

Summary

Mutliple cleanups to Purple.Message

* Reorder a bunch stuff so it is alphabetical * Added purple_message_new and deprecated the other constructors for it. * Added a new author-name property and marked the author property as deprecated for it. * Added new event and notice properties * De-dented get_property and set_property * Turned on warning for deprecated signals and properties in the devenv and purple unit tests. * Added purple_message_set_timestamp_now to set the timestamp to utc now

c5e01f2a91409fddd389d57d8cba1698b6fc2a2a

Issues

Description	From	Last Updated
+or	ivanhoe	July 13, 2024, 12:57 a.m.
s/join/joining	ivanhoe	July 13, 2024, 12:57 a.m.

Sorry this got so big and out of control. I could maybe break it up if necessary, but so much of it is just shuffling code around.

libpurple/purplemessage.c (Diff revision 1)
The issue has been resolved. Show all issues
```
+or
```
libpurple/purplemessage.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/join/joining
```

Change Summary:

fix typos

Commits:

	Summary	ID
	Mutliple cleanups to Purple.Message * Reorder a bunch stuff so it is alphabetical * Added purple_message_new and deprecated the other constructors for it. * Added a new author-name property and marked the author property as deprecated for it. * Added new event and notice properties * De-dented get_property and set_property * Turned on warning for deprecated signals and properties in the devenv and purple unit tests. * Added purple_message_set_timestamp_now to set the timestamp to utc now	3fa91c2b790aae0a3a2ffbbca709eff9422efa8e
	Mutliple cleanups to Purple.Message * Reorder a bunch stuff so it is alphabetical * Added purple_message_new and deprecated the other constructors for it. * Added a new author-name property and marked the author property as deprecated for it. * Added new event and notice properties * De-dented get_property and set_property * Turned on warning for deprecated signals and properties in the devenv and purple unit tests. * Added purple_message_set_timestamp_now to set the timestamp to utc now	c5e01f2a91409fddd389d57d8cba1698b6fc2a2a

Diff:

Revision 2 (+1842 -1346)

Show changes

	meson.build
	libpurple/purplemessage.h
	libpurple/purplemessage.c
	libpurple/tests/meson.build
	libpurple/tests/test_message.c

Ship it!

```
Ship It!
```

Status:: Completed

libpurple/purplemessage.c (Diff revision 1)

libpurple/purplemessage.c (Diff revision 1)