Summary

Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14

Review Request #3282 — Created July 6, 2024 and submitted July 9, 2024, 2:08 a.m.

Information

Owner

yoann.congal@smile.fr

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks

(aka void ()(void)) but is initialised with GtkItemFactoryCallback1 types

(aka void ()(void , guint,  GtkWidget )).
This is coherent with the gtk-2 documentation:


gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)

 entries : an array of GtkItemFactoryEntrys whose callback members must by of

 type GtkItemFactoryCallback1

But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to

GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint,  GtkWidget *)' {aka 'void (*)(void *, unsigned int,  struct _GtkWidget *)'} [-Wincompatible-pointer-types]
 3096 |         { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
      |                                                                  ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')

To fix this, explicitely cast to GtkItemFactoryCallback where needed.

Testing Done

Built with gcc-14, started and clicked on some affected menus

Commits

Summary	ID
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14 The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks (aka void ()(void)) but is initialised with GtkItemFactoryCallback1 types (aka void ()(void , guint, GtkWidget )). This is coherent with the gtk-2 documentation: > gtk_item_factory_create_items(..., GtkItemFactoryEntry entries,...) > entries : an array of GtkItemFactoryEntrys whose callback members must by of > type GtkItemFactoryCallback1 But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [0]). An exemple of this error: pidgin/gtkconv.c:3096:66: error: initialization of 'void ()(void)' from incompatible pointer type 'void ()(void , guint, GtkWidget )' {aka 'void ()(void , unsigned int, struct _GtkWidget )'} [-Wincompatible-pointer-types] 3096 \| { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb, \| ^~~~~~~~~~~~~~~~ pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback') To fix this, explicitely cast to GtkItemFactoryCallback where needed. Testing Done: Built with gcc-14, started and clicked on some affected menus [0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types	06721b86a5a8e6fb8163d9411a7778d2a0274b26

Summary

Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14

The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks (aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types (aka void (*)(void *, guint, GtkWidget *)). This is coherent with the gtk-2 documentation: > gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...) > entries : an array of GtkItemFactoryEntrys whose callback members must by of > type GtkItemFactoryCallback1 But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [0]). An exemple of this error: pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types] 3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb, | ^~~~~~~~~~~~~~~~ pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback') To fix this, explicitely cast to GtkItemFactoryCallback where needed. Testing Done: Built with gcc-14, started and clicked on some affected menus [0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types

06721b86a5a8e6fb8163d9411a7778d2a0274b26

Issues

Description	From	Last Updated
I've found a system where the const is a legitimate part of the type... I need to investiguate...	yoann.congal@smile.fr	July 7, 2024, 5:28 p.m.

libpurple/xmlnode.c (Diff revision 1)

The issue has been resolved. Show all issues

I've found a system where the const is a legitimate part of the type... I need to investiguate...

yoann.congal@smile.fr July 7, 2024, 5:14 p.m.

const was added in this commit of libxml2 : https://gitlab.gnome.org/GNOME/libxml2/-/commit/61034116d0a3c8b295c6137956adc3ae55720711 in >= v2.12.0
One of my systems is Debian/testing (with libxml2 at 2.9.14 so without the const)

The other one (fwiw a Yocto master) has libxml2 at 2.12.7 (with const)
Having the const is more future-proof, I'll remove its removal from this review.

Change Summary:

Removed xmlSAXHandler.serror related patch

Commits:

	Summary	ID
	Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14 The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks (aka void ()(void)) but is initialised with GtkItemFactoryCallback1 types (aka void ()(void , guint, GtkWidget )). This is coherent with the gtk-2 documentation: > gtk_item_factory_create_items(..., GtkItemFactoryEntry entries,...) > entries : an array of GtkItemFactoryEntrys whose callback members must by of > type GtkItemFactoryCallback1 But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [0]). An exemple of this error: pidgin/gtkconv.c:3096:66: error: initialization of 'void ()(void)' from incompatible pointer type 'void ()(void , guint, GtkWidget )' {aka 'void ()(void , unsigned int, struct _GtkWidget )'} [-Wincompatible-pointer-types] 3096 \| { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb, \| ^~~~~~~~~~~~~~~~ pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback') To fix this, explicitely cast to GtkItemFactoryCallback where needed. Testing Done: Built with gcc-14, started and clicked on some affected menus [0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types	06721b86a5a8e6fb8163d9411a7778d2a0274b26
	Fix incompatible pointer types for xmlSAXHandler.serror functions on gcc-14 The xmlSAXHandler.serror is of type xmlStructuredErrorFunc (aka void ()(void userData, xmlErrorPtr error)) but is initialized with void ()(void userData, const xmlErrorPtr error)) (note the extra const here -----------------------^ With GCC-14 this is an error (see [0]). For example: parser.c:200:9: error: initialization of 'void ()(void , xmlError )' {aka 'void ()(void , struct _xmlError )'} from incompatible pointer type 'void ()(void , const xmlError )' {aka 'void ()(void , const struct _xmlError )'} [-Wincompatible-pointer-types] 200 \| bonjour_parser_structured_error_handler /serror/ \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ parser.c:200:9: note: (near initialization for 'bonjour_parser_libxml.serror') To fix this, remove the const attribute to match the xmlStructuredErrorFunc struct. Testing Done: Built with gcc-14 [0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types	7b20c9a5df89b2c99921fa0c68b3754049e98d36
	Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14 The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks (aka void ()(void)) but is initialised with GtkItemFactoryCallback1 types (aka void ()(void , guint, GtkWidget )). This is coherent with the gtk-2 documentation: > gtk_item_factory_create_items(..., GtkItemFactoryEntry entries,...) > entries : an array of GtkItemFactoryEntrys whose callback members must by of > type GtkItemFactoryCallback1 But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [0]). An exemple of this error: pidgin/gtkconv.c:3096:66: error: initialization of 'void ()(void)' from incompatible pointer type 'void ()(void , guint, GtkWidget )' {aka 'void ()(void , unsigned int, struct _GtkWidget )'} [-Wincompatible-pointer-types] 3096 \| { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb, \| ^~~~~~~~~~~~~~~~ pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback') To fix this, explicitely cast to GtkItemFactoryCallback where needed. Testing Done: Built with gcc-14, started and clicked on some affected menus [0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types	06721b86a5a8e6fb8163d9411a7778d2a0274b26

Diff:

Revision 2 (+66 -66)

Show changes

	pidgin/gtkblist.c
	pidgin/gtkconv.c

Change Summary:: Focus the review only on the GtkItemFactoryEntry part
Summary:: Fix incompatible pointer types on gcc-14
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
Description:: ~
Fix incompatible-pointer-types errors on gcc-14(see gcc doc) for: GtkItemFactoryEntry/GtkItemFactoryCallbacks and xmlSAXHandler.serror/xmlStructuredErrorFunc
~
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
+ (aka void ()(void)) but is initialised with GtkItemFactoryCallback1 types
+ (aka void ()(void , guint, GtkWidget )).

~
See individual commits for details.
~
This is coherent with the gtk-2 documentation:
+
+

gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
entries : an array of GtkItemFactoryEntrys whose callback members must by of
type GtkItemFactoryCallback1

+
+
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
+ GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
+
+
An exemple of this error:
+
+
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
+
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
+
| ^~~~~~~~~~~~~~~~
+
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
+
+
+
To fix this, explicitely cast to GtkItemFactoryCallback where needed.

Ship it!

Nice work and thank you very much!

How would you like to be credited for this in our COPYRIGHT file?

yoann.congal@smile.fr July 8, 2024, 1:53 a.m.
```
"Yoann Congal" please :)
Thanks!
```

Status:: Completed

~		Fix incompatible-pointer-types errors on gcc-14(see gcc doc) for: GtkItemFactoryEntry/GtkItemFactoryCallbacks and xmlSAXHandler.serror/xmlStructuredErrorFunc
	~	The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
	+	(aka void ()(void)) but is initialised with GtkItemFactoryCallback1 types
	+	(aka void ()(void , guint, GtkWidget )).

~		See individual commits for details.
	~	This is coherent with the gtk-2 documentation:
	+
	+	gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...) entries : an array of GtkItemFactoryEntrys whose callback members must by of type GtkItemFactoryCallback1
	+
	+	But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
	+	GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
	+
	+	An exemple of this error:
	+
	+	`pidgin/gtkconv.c:3096:66: error: initialization of 'void ()(void)' from incompatible pointer type 'void ()(void , guint, GtkWidget )' {aka 'void ()(void , unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]`
	+	3096 \| { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
	+	\| ^~~~~~~~~~~~~~~~
	+	pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
	+
	+
	+	To fix this, explicitely cast to GtkItemFactoryCallback where needed.