Summary

Implement presenting and selecting conversations

Review Request #3255 — Created June 10, 2024 and submitted June 11, 2024, 2:25 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Implement Pidgin.DisplayWindow.select.

Display conversations when their present signal is emitted.

Call Purple.Conversation.present from Pidgin.ContactList when a contact is
activated.

Testing Done

Opened conversations from the contact list and verified they were selected properly.

Commits

Summary	ID
Implement presenting and selecting conversations Implement Pidgin.DisplayWindow.select. Display conversations when their present signal is emitted. Call Purple.Conversation.present from Pidgin.ContactList when a contact is activated.	d1daed44bc5dfab86534218d705b0d2df4ea66a3

Issues

Description	From	Last Updated
Is the wrapper item necessary? You could use pidgin_display_window_find_conversation_by_id with the conversation's id. Something similar is done in pidgin_display_window_add. Or …	ivanhoe	June 11, 2024, 2:02 p.m.
item is leaking	ivanhoe	June 11, 2024, 2:02 p.m.

pidgin/pidgindisplaywindow.c (Diff revision 1)

The issue has been dropped. Show all issues

Is the wrapper item necessary?
You could use pidgin_display_window_find_conversation_by_id with the conversation's id. Something similar is done in pidgin_display_window_add. Or is the conversation id not reliable?

grim June 11, 2024, 1:56 p.m.

I'm not sure, but I know this all needs to be cleaned up and I didn't want to complicated this review request with that cleanup.

pidgin/pidgindisplaywindow.c (Diff revision 1)
The issue has been resolved. Show all issues
```
item is leaking
```

Change Summary:

rebased and plugged the leak

Commits:

	Summary	ID
	Implement presenting and selecting conversations Implement Pidgin.DisplayWindow.select. Display conversations when their present signal is emitted. Call Purple.Conversation.present from Pidgin.ContactList when a contact is activated.	87882e8ead5ca8c32215453e3eb9d1aa98ad7d58
	Implement presenting and selecting conversations Implement Pidgin.DisplayWindow.select. Display conversations when their present signal is emitted. Call Purple.Conversation.present from Pidgin.ContactList when a contact is activated.	d1daed44bc5dfab86534218d705b0d2df4ea66a3

Diff:

Revision 2 (+168 -18)

Show changes

	pidgin/pidgincontactlist.c
	pidgin/pidgindisplaywindow.c
	pidgin/resources/display-window.ui

Ship it!

```
Ship It!
```

Status:: Completed