Summary

IRCv3: Implement join and part message handlers

Review Request #3235 — Created June 7, 2024 and submitted June 7, 2024, 10:46 p.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This only handle the RFC versions, we'll do extended-join later.

The TODO's are not meant to be done in this RR because they require additional code in IRCv3Connection, and once that's done we'll grab these then.

Testing Done

Connected to my local ergo and had another client join and part a few times while I verified that the member list was updated correctly.

Commits

Summary	ID
IRCv3: Implement join and part message handlers This only handle the RFC versions, we'll do extended-join later.	28a3d2a6f51fcc8f7d3633c62939603aa56c40d4

Issues

Description	From	Last Updated
Shouldn't this check if either nick or contact is actually non-NULL? Same issue in purple_ircv3_message_handler_part (line 142).	ivanhoe	June 7, 2024, 8:30 p.m.

protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)

The issue has been resolved. Show all issues

Shouldn't this check if either nick or contact is actually non-NULL?
Same issue in purple_ircv3_message_handler_part (line 142).

Change Summary:

rebase and add some additional testing to make sure we have a nick.

Commits:

	Summary	ID
	IRCv3: Implement join and part message handlers This only handle the RFC versions, we'll do extended-join later.	d9f6af1f886fecb8240c94cce9369bc3274a4388
	IRCv3: Implement join and part message handlers This only handle the RFC versions, we'll do extended-join later.	28a3d2a6f51fcc8f7d3633c62939603aa56c40d4

Diff:

Revision 2 (+316 -28)

	protocols/ircv3/purpleircv3connection.c
	protocols/ircv3/purpleircv3messagehandlers.h
	protocols/ircv3/purpleircv3messagehandlers.c

Ship it!