Summary

Add Conversation:alias and Conversation:title-for-display properties

Review Request #3216 — Created May 31, 2024 and submitted June 4, 2024, 6:48 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

3224

Reviewers

Groups

pidgin

People

Description

Add Conversation:alias and Conversation:title-for-display properties

Testing Done

Ran the turtles and ran the conversation unit tests under valgrind.

Commits

Summary	ID
Add Conversation:alias and Conversation:name-for-display properties	a166ad3581773466bb3a2caf1f37b24946c68af6

Issues

Description	From	Last Updated
s/the alias/alias	ivanhoe	June 4, 2024, 5:22 a.m.
This fails for me when running the test: # Start of conversation tests ok 1 /conversation/properties ok 2 /conversation/set-topic-full ** …	ivanhoe	June 4, 2024, 5:22 a.m.

Maybe name-for-display should be title-for-display instead? Thoughts?

Change Summary:

Renamed name-for-display to title-for-display.

Summary:

Add Conversation:alias and Conversation:name-for-display properties

Add Conversation:alias and Conversation:title-for-display properties

Description:

~		Add Conversation:alias and Conversation:name-for-display properties
	~	Add Conversation:alias and Conversation:title-for-display properties

Commits:

	Summary	ID
	Add Conversation:alias and Conversation:name-for-display properties	c59d6a678c67ebc13493bc9a34120db1ce62280f
	Add Conversation:alias and Conversation:name-for-display properties	977c9e19ad834c91af7f9db6fa4e15e6fabe1b07

Diff:

Revision 2 (+446 -2)

Show changes

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c
	libpurple/tests/test_conversation_manager.c

libpurple/purpleconversation.h (Diff revision 2)
The issue has been resolved. Show all issues
```
s/the alias/alias
```

libpurple/tests/test_conversation.c (Diff revision 2)

The issue has been resolved. Show all issues

This fails for me when running the test:
# Start of conversation tests
ok 1 /conversation/properties
ok 2 /conversation/set-topic-full
**
ERROR:../libpurple/tests/test_conversation.c:259:test_purple_conversation_title_for_display: assertion failed (counter == 1): (0 == 1)
not ok /conversation/title-for-display - ERROR:../libpurple/tests/test_conversation.c:259:test_purple_conversation_title_for_display: assertion failed (counter == 1): (0 == 1)

grim June 3, 2024, 6:43 p.m.

Weird, I thought I ran the tests... Either way, good catch!

Change Summary:

Addressed issues.

Commits:

	Summary	ID
	Add Conversation:alias and Conversation:name-for-display properties	977c9e19ad834c91af7f9db6fa4e15e6fabe1b07
	Add Conversation:alias and Conversation:name-for-display properties	a166ad3581773466bb3a2caf1f37b24946c68af6

Diff:

Revision 3 (+446 -2)

Show changes

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c
	libpurple/tests/test_conversation_manager.c

Ship it!

```
Ship It!
```

Status:: Completed