Summary

Add SASL support via HASL

Review Request #3212 — Created May 28, 2024 and submitted May 31, 2024, 6:17 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-10

Depends On

~~3205~~

Reviewers

Groups

pidgin

People

Description

Add SASL support via HASL

Testing Done

Connected to a local ergo and verified the traffic.
Also ran the turtles.

Commits

Summary	ID
Add SASL support via HASL	ed53b47278875e5f32e759cd2c0dae5e71ea5669

Issues

Description	From	Last Updated
It doesn't seem like you're checking SASL data now? This comment seems to be a leftover from the prpl.	QuLogic	May 31, 2024, 5:54 a.m.
0.2?	QuLogic	May 31, 2024, 5:54 a.m.
Any reason for not using the tag? This isn't even the latest commit either.	QuLogic	May 31, 2024, 5:54 a.m.

ibis/ibissasl.c (Diff revision 1)

The issue has been resolved. Show all issues

It doesn't seem like you're checking SASL data now? This comment seems to be a leftover from the prpl.

ibis/ibisversion.h (Diff revision 1)
The issue has been resolved. Show all issues
```
0.2?
```

subprojects/hasl.wrap (Diff revision 1)

The issue has been resolved. Show all issues

Any reason for not using the tag? This isn't even the latest commit either.

grim May 31, 2024, 5:50 a.m.

Looks like I just grabbed the version that fixed the build on freebsd, but we should probably just cut a 0.3 of hasl anyways.

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Add SASL support via HASL	c5f1c9beb42e22cd3d3de41028c11504fdda1436
	Add SASL support via HASL	df959a64b40624f3c64f461853de9adbb854d5e8

Diff:

Revision 2 (+1402 -80)

Show changes

	meson.build
	ibis/ibiscapabilities.h
	ibis/ibiscapabilities.c
	ibis/ibisclient.h
	ibis/ibisclient.c
	ibis/ibisconstants.h
	ibis/ibissasl.h
	ibis/ibissasl.c
	6 more

Ship it!

```
Ship It!
```

Change Summary:

Removed the 0.2 stuff as we haven't released 0.1 yet so we can sneak this into 0.1

Commits:

	Summary	ID
	Add SASL support via HASL	df959a64b40624f3c64f461853de9adbb854d5e8
	Add SASL support via HASL	ed53b47278875e5f32e759cd2c0dae5e71ea5669

Diff:

Revision 3 (+1352 -78)

Show changes

	meson.build
	ibis/ibiscapabilities.h
	ibis/ibiscapabilities.c
	ibis/ibisclient.h
	ibis/ibisclient.c
	ibis/ibisconstants.h
	ibis/ibissasl.h
	ibis/ibissasl.c
	5 more

Ship it!

```
Ship It!
```

Status:: Completed