Summary

Add all of the missing constants for errors, messages, and replies.

Review Request #3209 — Created May 27, 2024 and submitted June 1, 2024, 7:44 p.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Blocks

3205, 3210

Reviewers

Groups

pidgin

People

Description

Add all of the missing constants for errors, messages, and replies.

Testing Done

Ran the turtles.

Commits

Summary	ID
Add all of the missing constants for errors, messages, and replies.	4f9b217fbe48794830a596f8c459ca8e960a20f4

Issues

Description	From	Last Updated
According to my sources 347 should be RPL_ENDOFINVITELIST I didn't find what 337 is though. Same issue with 346 and …	ivanhoe	May 31, 2024, 7:17 p.m.
missed an E here	ivanhoe	June 1, 2024, 8:15 a.m.
I think this should just be NAMREPLY without the E. Sources: https://irc.dalexhd.dev/ https://www.irc-mania.de/rfc1459/	ivanhoe	June 1, 2024, 8:15 a.m.

ibis/ibisconstants.h (Diff revision 1)

The issue has been dropped. Show all issues

According to my sources 347 should be RPL_ENDOFINVITELIST
I didn't find what 337 is though.

Same issue with 346 and 336.

Sources:
https://irc.dalexhd.dev/
https://datatracker.ietf.org/doc/rfc2812/

grim May 30, 2024, 10:12 p.m.

Oh fun... guess I'll ask in the ircv3 irc channel... https://modern.ircdocs.horse/#rplendofinvitelist-337

grim May 31, 2024, 2:08 a.m.

per this issue https://github.com/ircdocs/modern-irc/issues/42 it looks like the ircv3 docs are more up to date and accurate. So I'd tend to lean towards them. Thoughts?

ivanhoe May 31, 2024, 7:20 p.m.
```
Yeah, that seems reasonable.
```

ibis/ibisconstants.h (Diff revision 1)

The issue has been resolved. Show all issues

I think this should just be NAMREPLY without the E.

Sources:
https://irc.dalexhd.dev/
https://www.irc-mania.de/rfc1459/

grim May 30, 2024, 10:12 p.m.

good catch, looks like i just typoed it. https://modern.ircdocs.horse/#rplnamreply-353

Change Summary:

rebase and fix typo.

Commits:

	Summary	ID
	Add all of the missing constants for errors, messages, and replies.	6c2e2a42913b68029fb5daf9a8840cce75efe105
	Add all of the missing constants for errors, messages, and replies.	66fab241973f5a9550c2cfdd3544697fceb79c10

Diff:

Revision 2 (+2580 -60)

Show changes

ibis/ibisconstants.h

ibis/ibisconstants.h (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
missed an E here
```

Change Summary:

rebased and droped an e.

Commits:

	Summary	ID
	Add all of the missing constants for errors, messages, and replies.	66fab241973f5a9550c2cfdd3544697fceb79c10
	Add all of the missing constants for errors, messages, and replies.	4f9b217fbe48794830a596f8c459ca8e960a20f4

Diff:

Revision 3 (+2580 -60)

Show changes

ibis/ibisconstants.h

Ship it!

```
Ship It!
```

Status:: Completed