Summary

Move the IRCv3 protocol plugin to our new Ibis library

Review Request #3203 — Created May 24, 2024 and submitted May 31, 2024, 6 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

3208, 3207

Reviewers

Groups

pidgin

People

Description

Move the IRCv3 protocol plugin to our new Ibis library

Testing Done

Ran the turtles.
Connected to a local ergo and sent privmsges to other users, also forced a chat via code (that was removed) to make sure the title handlers were working.

Commits

Summary	ID
Move the IRCv3 protocol plugin to our new Ibis library	f726140e4970af0f4eaa68081a07d61cea0f81be

Issues

Description	From	Last Updated
Should we also set purple to disconnected if the Ibis client is disconnected?	QuLogic	May 31, 2024, 5:53 a.m.
Might as well use NULLs here?	QuLogic	May 31, 2024, 5:53 a.m.

protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we also set purple to disconnected if the Ibis client is disconnected?
```
protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Might as well use NULLs here?
```

Change Summary:

Addressed issues.

Commits:

	Summary	ID
	Move the IRCv3 protocol plugin to our new Ibis library	ddb5ae359b8192f5d175c489e0792bef7bc710ae
	Move the IRCv3 protocol plugin to our new Ibis library	f726140e4970af0f4eaa68081a07d61cea0f81be

Diff:

Revision 2 (+400 -10940)

Show changes

	protocols/ircv3/meson.build
	protocols/ircv3/purpleircv3capabilities.h
	protocols/ircv3/purpleircv3capabilities.c
	protocols/ircv3/purpleircv3connection.h
	protocols/ircv3/purpleircv3connection.c
	protocols/ircv3/purpleircv3constants.h
	protocols/ircv3/purpleircv3core.c
	protocols/ircv3/purpleircv3ctcp.h
	19 more

Ship it!

```
Ship It!
```

Status:: Completed