Summary

Add a ctcp property to IbisMessage

Review Request #3200 — Created May 24, 2024 and submitted May 24, 2024, 5:58 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This property will be set by the parser but can be set on any message if it
is a PRIVMSG or NOTICE. While parsing the leading and trailing \001 will be
removed.

Testing Done

Ran the message and parser tests under valgrind.
Called in the turtles for the rest.

Commits

Summary	ID
Add a ctcp property to IbisMessage This property will be set by the parser but can be set on any message if it is a PRIVMSG or NOTICE. While parsing the leading and trailing \001 will be removed.	eb367af0fae6ceb43435da314472846f9c54e245

Issues

Description	From	Last Updated
There are two 'if' in this sentence; should one be an 'of', or should there be an 'and'/'or' somewhere?	QuLogic	May 24, 2024, 5:57 a.m.
No apostrophe.	QuLogic	May 24, 2024, 5:57 a.m.

ibis/ibismessage.c (Diff revision 1)

The issue has been resolved. Show all issues

There are two 'if' in this sentence; should one be an 'of', or should there be an 'and'/'or' somewhere?

ibis/ibismessage.c (Diff revision 1)
The issue has been resolved. Show all issues
```
No apostrophe.
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Add a ctcp property to IbisMessage This property will be set by the parser but can be set on any message if it is a PRIVMSG or NOTICE. While parsing the leading and trailing \001 will be removed.	b0bc56f5317c4ce85ad8045027ae4513f8b21532
	Add a ctcp property to IbisMessage This property will be set by the parser but can be set on any message if it is a PRIVMSG or NOTICE. While parsing the leading and trailing \001 will be removed.	eb367af0fae6ceb43435da314472846f9c54e245

Diff:

Revision 2 (+658 -16)

Show changes

	ibis/ibisconstants.h
	ibis/ibismessage.h
	ibis/ibismessage.c
	ibis/tests/test_message.c
	ibis/tests/test_parser.c

Ship it!

```
Ship It!
```

Status:: Completed