Summary

Add additional properties required for registration to IbisClient

Review Request #3189 — Created May 21, 2024 and submitted May 21, 2024, 4:48 a.m.

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Groups

People

Description

Add additional properties required for registration to IbisClient

Testing Done

Ran the turtles and ran the client unit tests under valgrind.

Valgrind is saying there's a potential leak in the alt_nick_empty test but we've seen this before as its in glib.

Commits

Summary	ID
Add additional properties required for registration to IbisClient	1ac13bcc09f0fcca12af5c553a1599f63ca7314c

Issues

Description	From	Last Updated
username	QuLogic	May 21, 2024, 4:47 a.m.
This isn't mentioned in the ibis_client_get_realname docs. And I don't think the tests really check this since they don't set …	QuLogic	May 21, 2024, 4:44 a.m.
Ditto.	QuLogic	May 21, 2024, 4:44 a.m.
its	QuLogic	May 21, 2024, 4:44 a.m.

ibis/ibisclient.c (Diff revision 1)

The issue has been resolved. Show all issues

This isn't mentioned in the ibis_client_get_realname docs. And I don't think the tests really check this since they don't set nick.

ibis/ibisclient.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
ibis/tests/test_client.c (Diff revision 1)
The issue has been resolved. Show all issues
```
its
```

Change Summary:

addressed issues and added some unit tests for the fallback for realname and username.

Commits:

	Summary	ID
	Add additional properties required for registration to IbisClient	110951ca5498b2eb4025dd29651f4d80da7d7b72
	Add additional properties required for registration to IbisClient	22790df625d8566989720ca43c0790e491ce48fd

Diff:

Revision 2 (+1096 -2)

ibis/ibisclient.h (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
username
```

Change Summary:

fix copy paste error

Commits:

	Summary	ID
	Add additional properties required for registration to IbisClient	22790df625d8566989720ca43c0790e491ce48fd
	Add additional properties required for registration to IbisClient	1ac13bcc09f0fcca12af5c553a1599f63ca7314c

Diff:

Revision 3 (+1096 -2)

Ship it!