-
-
Note that this nothing if
*error == NULL, meaning no error will be set ifconnection == NULL. Also, this could beg_prefix_error_literalinstead. -
ibis_client_disconnectalso seems to assume that it's already connected, as it tries to close the streams, so this might not be the right call here.Just setting the error, state, and clearing the cancellable may be easier?
-
I'm not sure you need the
if, since when the conditions fail, the functions would do what we expect.
Implement Client.connect
Review Request #3185 — Created May 14, 2024 and submitted
Implement Client.connect
Compiled and ran the turtles.
We don't really have a way to test a TCP connection at the moment.
| Summary | ID |
|---|---|
| 167951d272d01cd356a2adeeb22a6d3ea06e02e3 |
| Description | From | Last Updated |
|---|---|---|
|
Note that this nothing if *error == NULL, meaning no error will be set if connection == NULL. Also, this … |
 QuLogic
|
|
|
ibis_client_disconnect also seems to assume that it's already connected, as it tries to close the streams, so this might not … |
QuLogic
|
|
|
I'm not sure you need the if, since when the conditions fail, the functions would do what we expect. |
QuLogic
|
|
|
OK, but do you want it to error out if connection == NULL, or is that guaranteed to have an … |
QuLogic
|
|
|
This is still a problem because client->stream is still NULL as ibis_client_start hasn't been called. |
QuLogic
|
- Change Summary:
-
rebased and addressed issues.
- Commits:
-
Summary ID cbbe1070f2de6d3a13f111b835bccdf039d17ada 2b889dd1d20b841ac22ab082165285e4d68beca8 - Diff:
-
Revision 2 (+164 -22)
- Change Summary:
-
rebased and addressed issues.
- Commits:
-
Summary ID 2b889dd1d20b841ac22ab082165285e4d68beca8 66489aaafaa7c125e4fdcb2ae9b618a11a48c400 - Diff:
-
Revision 3 (+170 -28)
- Change Summary:
-
removed a redundant if on whether or not to enable tls.
- Commits:
-
Summary ID 66489aaafaa7c125e4fdcb2ae9b618a11a48c400 167951d272d01cd356a2adeeb22a6d3ea06e02e3 - Diff:
-
Revision 4 (+164 -28)