Summary

Update Capabilities to use the new signaling API

Review Request #3184 — Created May 14, 2024 and submitted May 17, 2024, 3:05 a.m.

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Groups

People

Description

Update Capabilities to use the new signaling API

Testing Done

Compiled. There aren't any tests for capabilities yet as we should probably build a gadget to handle request/response during testing.

Commits

Summary	ID
Update Capabilities to use the new signaling API	42587dfc4129775806f667018123fde764320347

Issues

Description	From	Last Updated
client	QuLogic	May 17, 2024, 2:41 a.m.
I'm not sure why we need this variable? Can just pass params[1] to g_utf8_strup.	QuLogic	May 17, 2024, 2:41 a.m.

ibis/ibiscapabilities.c (Diff revision 1)
The issue has been resolved. Show all issues
```
client
```

ibis/ibiscapabilities.c (Diff revision 1)

The issue has been resolved. Show all issues

I'm not sure why we need this variable? Can just pass params[1] to g_utf8_strup.

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Update Capabilities to use the new signaling API	6eac65cc1a4945b7664113ecdc2fc776fb948d97
	Update Capabilities to use the new signaling API	42587dfc4129775806f667018123fde764320347

Diff:

Revision 2 (+330 -326)

Ship it!