Summary

Move the parser to use signals instead of a hash table for handlers

Review Request #3180 — Created May 14, 2024 and submitted May 14, 2024, 4:41 a.m.

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

Depends On

Groups

People

Description

This is being done mostly to allow language bindings to use the library but it
does also simplify passing data around to the handlers and what not.

Testing Done

Ran the unit tests under valgrind and had the turtles do a check as well.

Commits

Summary	ID
Move the parser to use signals instead of a hash table for handlers This is being done mostly to allow language bindings to use the library but it does also simplify passing data around to the handlers and what not.	9934f909cb92adcf0de6a8ae1db50d9c9ea99bcf

Issues

Description	From	Last Updated
Shouldn't the quark be using the upper_command?	QuLogic	May 14, 2024, 4:39 a.m.
Trailing \.	QuLogic	May 14, 2024, 4:33 a.m.
Don't you usually clear the 1 stuff at the end of the test?	QuLogic	May 14, 2024, 4:33 a.m.
Extra 'the'	QuLogic	May 14, 2024, 4:33 a.m.

This was a first pass, but I have other ideas to make this better/easier to hold back on this one for the moment.

ibis/ibismessage.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing \.
```
ibis/tests/test_message.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Don't you usually clear the 1 stuff at the end of the test?
```
ibis/tests/test_parser.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Extra 'the'
```

Change Summary:

make ibis_parser_parse return the message and move the message signal to the client.

Commits:

	Summary	ID
	Move the parser to use signals instead of a hash table for handlers This is being done mostly to allow language bindings to use the library but it does also simplify passing data around to the handlers and what not.	b24e4726c32cdeac0d28e73fe0c4a9a6d447047c
	Move the parser to use signals instead of a hash table for handlers This is being done mostly to allow language bindings to use the library but it does also simplify passing data around to the handlers and what not.	56e4ab14a5dc51523fe3105743818d870e3fe179

Diff:

Revision 2 (+260 -452)

ibis/ibisclient.c (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Shouldn't the quark be using the upper_command?
```

Change Summary:

make sure to normalize the quark as well.

Commits:

	Summary	ID
	Move the parser to use signals instead of a hash table for handlers This is being done mostly to allow language bindings to use the library but it does also simplify passing data around to the handlers and what not.	56e4ab14a5dc51523fe3105743818d870e3fe179
	Move the parser to use signals instead of a hash table for handlers This is being done mostly to allow language bindings to use the library but it does also simplify passing data around to the handlers and what not.	9934f909cb92adcf0de6a8ae1db50d9c9ea99bcf

Diff:

Revision 3 (+262 -452)

Ship it!

ibis/ibismessage.c (Diff revision 1)

ibis/tests/test_message.c (Diff revision 1)

ibis/tests/test_parser.c (Diff revision 1)

ibis/ibisclient.c (Diff revisions 1 - 2)