Summary

Add purple_conversation_send_message_async and _finish

Review Request #3139 — Created April 19, 2024 and submitted April 25, 2024, 9:08 p.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Also make purple_message_set_error not take ownership of the error as that will
complicate things and it wasn't implemented properly anyways.

Testing Done

Just had the turtles do their thing. There are no unit tests for sending messages right now due to complexity.

Commits

Summary	ID
Add purple_conversation_send_message_async and _finish Also make purple_message_set_error not take ownership of the error as that will complicate things and it wasn't implemented properly anyways.	3e0422d337d04ddb9fce08ee75cf2ede59ee6ddb

Issues

Description	From	Last Updated
*its	ivanhoe	April 25, 2024, 11:34 a.m.
Shouldn't this be task instead of result?	ivanhoe	April 25, 2024, 11:34 a.m.

libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
*its
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Shouldn't this be task instead of result?
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Add purple_conversation_send_message_async and _finish Also make purple_message_set_error not take ownership of the error as that will complicate things and it wasn't implemented properly anyways.	74b0d614a3ab99ffb3ffb48a6212a75130645921
	Add purple_conversation_send_message_async and _finish Also make purple_message_set_error not take ownership of the error as that will complicate things and it wasn't implemented properly anyways.	3e0422d337d04ddb9fce08ee75cf2ede59ee6ddb

Diff:

Revision 2 (+308 -12)

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/purplemessage.h
	libpurple/purplemessage.c

Ship it!